You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Takashi Yonebayashi (JIRA)" <ji...@apache.org> on 2010/11/30 01:21:11 UTC
[jira] Created: (THRIFT-1009) TUnion does not correctly deep copy a
ByteBuffer
TUnion does not correctly deep copy a ByteBuffer
------------------------------------------------
Key: THRIFT-1009
URL: https://issues.apache.org/jira/browse/THRIFT-1009
Project: Thrift
Issue Type: Bug
Components: Java - Library
Affects Versions: 0.5
Reporter: Takashi Yonebayashi
Priority: Minor
Attachments: THRIFT-1009.patch
When a TUnion makes a deep copy of an object, it currently returns the original byte buffer when the union is set to be a byte buffer.
This should be changed to a TBaseHelper.copyBinary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-1009) TUnion does not correctly deep copy a
ByteBuffer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1009.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.6
Assignee: Takashi Yonebayashi
I just committed this. Thanks for the patch, Takashi?
> TUnion does not correctly deep copy a ByteBuffer
> ------------------------------------------------
>
> Key: THRIFT-1009
> URL: https://issues.apache.org/jira/browse/THRIFT-1009
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Takashi Yonebayashi
> Assignee: Takashi Yonebayashi
> Priority: Minor
> Fix For: 0.6
>
> Attachments: THRIFT-1009.patch
>
>
> When a TUnion makes a deep copy of an object, it currently returns the original byte buffer when the union is set to be a byte buffer.
> This should be changed to a TBaseHelper.copyBinary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-1009) TUnion does not
correctly deep copy a ByteBuffer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965031#action_12965031 ]
Bryan Duxbury edited comment on THRIFT-1009 at 11/29/10 7:42 PM:
-----------------------------------------------------------------
I just committed this. Thanks for the patch, Takashi!
was (Author: bryanduxbury):
I just committed this. Thanks for the patch, Takashi?
> TUnion does not correctly deep copy a ByteBuffer
> ------------------------------------------------
>
> Key: THRIFT-1009
> URL: https://issues.apache.org/jira/browse/THRIFT-1009
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Takashi Yonebayashi
> Assignee: Takashi Yonebayashi
> Priority: Minor
> Fix For: 0.6
>
> Attachments: THRIFT-1009.patch
>
>
> When a TUnion makes a deep copy of an object, it currently returns the original byte buffer when the union is set to be a byte buffer.
> This should be changed to a TBaseHelper.copyBinary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1009) TUnion does not correctly deep copy a
ByteBuffer
Posted by "Takashi Yonebayashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Takashi Yonebayashi updated THRIFT-1009:
----------------------------------------
Attachment: THRIFT-1009.patch
> TUnion does not correctly deep copy a ByteBuffer
> ------------------------------------------------
>
> Key: THRIFT-1009
> URL: https://issues.apache.org/jira/browse/THRIFT-1009
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Takashi Yonebayashi
> Priority: Minor
> Attachments: THRIFT-1009.patch
>
>
> When a TUnion makes a deep copy of an object, it currently returns the original byte buffer when the union is set to be a byte buffer.
> This should be changed to a TBaseHelper.copyBinary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.