You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/01/12 17:25:19 UTC
[GitHub] [fineract] vorburger opened a new pull request #689: introduce
Checkstyle, start enforcing whitespace related rules (FINERACT-821)
vorburger opened a new pull request #689: introduce Checkstyle, start enforcing whitespace related rules (FINERACT-821)
URL: https://github.com/apache/fineract/pull/689
Once #688 which bulk cleans up all existing whitespace issues,
after a rebase and verification (or more PRs) that there are no other new issues,
this PR contributes an initial Checkstyle configuration which will fails builds/PR for new whitespace issues.
The initial Checkstyle XML configuration contributed here has many more rules, but all non whitespace related ones are still commented out for now; the idea being that we (myself or, hopefully, other contributors!) then gradually enable more of those rules, after fixing existing violations.
See https://issues.apache.org/jira/browse/FINERACT-821 for full background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #689: introduce Checkstyle,
start enforcing whitespace related rules (FINERACT-821)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #689: introduce Checkstyle, start enforcing whitespace related rules (FINERACT-821)
URL: https://github.com/apache/fineract/pull/689#issuecomment-576035647
@awasum FYI with me just having merged #688, this one is now ready! Would you do the honours of reviewing it (also to get familiar with it, in case you would consider make some further contributions based on this?), and merging ASAP?
PS: This build will most likely fail, because it's Sunday, due to [FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820) (what a PITA, is anyone ever going to fix that?). Perhaps you'd like to Close and Re-Open it tomorrow, before merging it to convince yourself that the Checkstyle really fully passes? (Which it does, I've of course tested this locally.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum merged pull request #689: introduce Checkstyle,
start enforcing whitespace related rules (FINERACT-821)
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #689: introduce Checkstyle, start enforcing whitespace related rules (FINERACT-821)
URL: https://github.com/apache/fineract/pull/689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #689: introduce Checkstyle,
start enforcing whitespace related rules (FINERACT-821)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #689: introduce Checkstyle, start enforcing whitespace related rules (FINERACT-821)
URL: https://github.com/apache/fineract/pull/689#issuecomment-576873237
@awasum will you have a moment to review and (hopefully) merge this some time in the next few days?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #689: introduce Checkstyle,
start enforcing whitespace related rules (FINERACT-821)
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #689: introduce Checkstyle, start enforcing whitespace related rules (FINERACT-821)
URL: https://github.com/apache/fineract/pull/689#issuecomment-577040499
> @awasum will you have a moment to review and (hopefully) merge this some time in the next few days?
@vorburger Sorry, I have been so busy at work. Please, I will review this latest this weekend. Thanks for the opportunity and the reminder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services