You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/11 08:50:05 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2397:
api server exception management and code optimization (#397)
codecov-io commented on issue #2397: api server exception management and code optimization (#397)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2397#issuecomment-612369780
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=h1) Report
> Merging [#2397](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4c90f04bb22c67475b7ccdebb62414a02a28c7eb&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `15.55%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2397 +/- ##
============================================
- Coverage 32.79% 32.78% -0.02%
Complexity 2266 2266
============================================
Files 421 423 +2
Lines 19788 19798 +10
Branches 2353 2356 +3
============================================
Hits 6490 6490
- Misses 12720 12727 +7
- Partials 578 581 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inscheduler/api/exceptions/ApiServerException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2V4Y2VwdGlvbnMvQXBpU2VydmVyRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lphinscheduler/api/service/AccessTokenService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWNjZXNzVG9rZW5TZXJ2aWNlLmphdmE=) | `88.13% <0.00%> (-3.10%)` | `10.00 <0.00> (ø)` | |
| [...cheduler/api/controller/AccessTokenController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWNjZXNzVG9rZW5Db250cm9sbGVyLmphdmE=) | `8.33% <5.55%> (+3.20%)` | `2.00 <1.00> (ø)` | |
| [.../org/apache/dolphinscheduler/api/utils/Result.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1Jlc3VsdC5qYXZh) | `55.55% <21.42%> (-37.78%)` | `8.00 <2.00> (ø)` | |
| [...nscheduler/api/exceptions/ApiExceptionHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2V4Y2VwdGlvbnMvQXBpRXhjZXB0aW9uSGFuZGxlci5qYXZh) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.07% <0.00%> (-2.88%)` | `9.00% <0.00%> (-2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=footer). Last update [4c90f04...2085d45](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2397?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services