You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/21 19:46:19 UTC
[GitHub] [hive] HunterL opened a new pull request #1290: HIVE-23874: Added debug line for fetchRequest in the HiveQueryResultSet
HunterL opened a new pull request #1290:
URL: https://github.com/apache/hive/pull/1290
Debugging fetch request will help in troubleshooting client side requests to HS2.
hive-jdbc probably needs better logging overall, will likely be taking a look at that in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr merged pull request #1290: HIVE-23874: Added debug line for fetchRequest in the HiveQueryResultSet
Posted by GitBox <gi...@apache.org>.
belugabehr merged pull request #1290:
URL: https://github.com/apache/hive/pull/1290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] HunterL commented on pull request #1290: HIVE-23874: Added debug line for fetchRequest in the HiveQueryResultSet
Posted by GitBox <gi...@apache.org>.
HunterL commented on pull request #1290:
URL: https://github.com/apache/hive/pull/1290#issuecomment-663150210
Closed and Reopen to trigger CI builds again (flaky test failed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #1290: HIVE-23874: Added debug line for fetchRequest in the HiveQueryResultSet
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #1290:
URL: https://github.com/apache/hive/pull/1290#discussion_r458813891
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java
##########
@@ -349,7 +350,7 @@ public boolean next() throws SQLException {
fetchedRows = RowSetFactory.create(results, protocol);
fetchedRowsItr = fetchedRows.iterator();
}
-
+
Review comment:
Please remove this superfluous whitespace
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java
##########
@@ -341,6 +341,7 @@ public boolean next() throws SQLException {
if (fetchedRows == null || !fetchedRowsItr.hasNext()) {
TFetchResultsReq fetchReq = new TFetchResultsReq(stmtHandle,
orientation, fetchSize);
+ LOG.debug(fetchReq.toString());
Review comment:
Take a look at this:
http://www.slf4j.org/faq.html#logging_performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr closed pull request #1290: HIVE-23874: Added debug line for fetchRequest in the HiveQueryResultSet
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #1290:
URL: https://github.com/apache/hive/pull/1290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] HunterL closed pull request #1290: HIVE-23874: Added debug line for fetchRequest in the HiveQueryResultSet
Posted by GitBox <gi...@apache.org>.
HunterL closed pull request #1290:
URL: https://github.com/apache/hive/pull/1290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org