[GitHub] incubator-carbondata pull request #411: [WIP]Support data type: date and cha...

[jackylk <gi...@git.apache.org>]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/411#discussion_r91828568
  
    --- Diff: core/src/test/java/org/apache/carbondata/scan/collector/impl/DictionaryBasedResultCollectorTest.java ---
    @@ -162,7 +162,7 @@
         new MockUp<DirectDictionaryKeyGeneratorFactory>() {
           @SuppressWarnings("unused") @Mock DirectDictionaryGenerator getDirectDictionaryGenerator(
               DataType dataType) {
    -        if (dataType == DataType.TIMESTAMP) return new TimeStampDirectDictionaryGenerator(
    +        if (dataType == DataType.TIMESTAMP || dataType == DataType.DATE) return new TimeStampDirectDictionaryGenerator(
    --- End diff --
    
    please add `{`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---