You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/31 14:31:16 UTC
[GitHub] [incubator-devlake] e2corporation opened a new pull request, #3626: refactor: update integration context initial props
e2corporation opened a new pull request, #3626:
URL: https://github.com/apache/incubator-devlake/pull/3626
### Config-UI / Integrations Context
- [x] Fix Integrations Context Initial Properties case for `Registry`, `Plugins` and `Integrations` (Shape)
### Does this close any open issues?
Closes #3625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3626: refactor: update integration context initial props
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #3626:
URL: https://github.com/apache/incubator-devlake/pull/3626#discussion_r1010440041
##########
config-ui/src/store/integrations-context.jsx:
##########
@@ -34,9 +34,9 @@ const IntegrationsContext = React.createContext({
export const IntegrationsContextProvider = (props) => {
const {
- registry: Registry,
- plugins: Plugins,
- integrations: Integrations,
+ Registry,
+ Plugins,
+ Integrations,
Review Comment:
But `useIntergrations` only export `registry/...`
https://github.com/apache/incubator-devlake/blob/c215d73fba30c1c0114ab5be871f15b3645d6a53/config-ui/src/hooks/useIntegrations.jsx#L298-L319
It looks like it can not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #3626: refactor: update integration context initial props
Posted by GitBox <gi...@apache.org>.
likyh merged PR #3626:
URL: https://github.com/apache/incubator-devlake/pull/3626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3626: refactor: update integration context initial props
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #3626:
URL: https://github.com/apache/incubator-devlake/pull/3626#discussion_r1010444760
##########
config-ui/src/store/integrations-context.jsx:
##########
@@ -34,9 +34,9 @@ const IntegrationsContext = React.createContext({
export const IntegrationsContextProvider = (props) => {
const {
- registry: Registry,
- plugins: Plugins,
- integrations: Integrations,
+ Registry,
+ Plugins,
+ Integrations,
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3626: refactor: update integration context initial props
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #3626:
URL: https://github.com/apache/incubator-devlake/pull/3626#discussion_r1009501228
##########
config-ui/src/store/integrations-context.jsx:
##########
@@ -34,9 +34,9 @@ const IntegrationsContext = React.createContext({
export const IntegrationsContextProvider = (props) => {
const {
- registry: Registry,
- plugins: Plugins,
- integrations: Integrations,
+ Registry,
+ Plugins,
+ Integrations,
Review Comment:
Has this change been tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org