You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2018/03/29 08:01:47 UTC
Review Request 66351: ATLAS-2522:Improvement to HBase import script
functionality
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66351/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-2522:Improvement to HBase import script functionality
Diffs
-----
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java d2e9f99
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java 6c195b7
Diff: https://reviews.apache.org/r/66351/diff/1/
Testing
-------
Tested in Local VM
Thanks,
Ramesh Mani
Re: Review Request 66351: ATLAS-2522:Improvement to HBase import
script functionality
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66351/#review200200
-----------------------------------------------------------
Fix it, then Ship it!
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java
Line 39 (original), 45 (patched)
<https://reviews.apache.org/r/66351/#comment280843>
consider replacing line 45-52 with 2 if block:
if (importNameSpace) {
namespaceToImport = cmd.getOptionValue("n");
}
if (importTable) {
tableToImport = cmd.getOptionValue("t");
}
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java
Lines 74 (patched)
<https://reviews.apache.org/r/66351/#comment280844>
!StringUtils.isEmpty(namespaceToImport) => StringUtils.isNotEmpty(namespaceToImport)
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java
Lines 88 (patched)
<https://reviews.apache.org/r/66351/#comment280845>
!CollectionUtils.isEmpty(matchingNameSpaceDescriptors) => CollectionUtils.isNotEmpty(matchingNameSpaceDescriptors)
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java
Lines 93 (patched)
<https://reviews.apache.org/r/66351/#comment280846>
It would be helpful to pass the namespace name in the exception message for better debugging.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java
Line 352 (original), 364 (patched)
<https://reviews.apache.org/r/66351/#comment280847>
do we need to do a getEntity() after createEntity() ? Doesn't entityMutationResponse have all the information? I don't see the ret value used else where in the caller.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java
Line 367 (original), 381 (patched)
<https://reviews.apache.org/r/66351/#comment280848>
same here - getEntity() after updateEntity() is needed?
- Sarath Subramanian
On March 29, 2018, 1:01 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66351/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 1:01 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2522:Improvement to HBase import script functionality
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java d2e9f99
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java 6c195b7
>
>
> Diff: https://reviews.apache.org/r/66351/diff/1/
>
>
> Testing
> -------
>
> Tested in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 66351: ATLAS-2522:Improvement to HBase import
script functionality
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66351/
-----------------------------------------------------------
(Updated March 29, 2018, 6:15 p.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Fixed review comments
Repository: atlas
Description
-------
ATLAS-2522:Improvement to HBase import script functionality
Diffs (updated)
-----
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntities.java d2e9f99
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java 6c195b7
Diff: https://reviews.apache.org/r/66351/diff/2/
Changes: https://reviews.apache.org/r/66351/diff/1-2/
Testing (updated)
-------
Tested in Local VM
./import-hbase.sh -n testnm.*
./import-hbase.sh -t testtable.*
./import-hbase.sh -n testnm1 -t testable1
Thanks,
Ramesh Mani