You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/22 07:34:40 UTC
[GitHub] [camel] avaz opened a new pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
avaz opened a new pull request #4274:
URL: https://github.com/apache/camel/pull/4274
This PR addresses [CAMEL-14929](https://issues.apache.org/jira/browse/CAMEL-14929) which the goal is to give an option in to do consume S3 objects into the memory and let them be manipulated by the next steps in the pipeline.
With such behaviour is possible to process large S3 objects in a more memory friendly fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4274:
URL: https://github.com/apache/camel/pull/4274#issuecomment-706705116
The endpoint is used anyway, so I don't way why the test with localstack should not be used. Do you have docker running? By the way, the Pr is enough. For the javadoc, you need to do clean install -DskipTests, btw I'll do that once I merge. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4274:
URL: https://github.com/apache/camel/pull/4274#issuecomment-706716829
Thanks, merged on master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] avaz commented on pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
Posted by GitBox <gi...@apache.org>.
avaz commented on pull request #4274:
URL: https://github.com/apache/camel/pull/4274#issuecomment-706577296
Hi @oscerd ,
TL;DR
Integration tests are added for the changes related to this PR as I couldn't get to add localstack tests.
I couldn't add tests using the localstack due the fact that localstack test seems to interact with camel in a different way, essentially the functional class the I made the change (`src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Endpoint.java`) is not being called by localstack. I checked that by debugging one of localstack tests (`src/test/java/org/apache/camel/component/aws2/s3/localstack/S3ConsumerLocalstackTest.java`) and the debugger didn't hit the `AWS2S3Endpoint.java` class. Therefore I decided to add integration test instead and I did that in the class `src/test/java/org/apache/camel/component/aws2/s3/integration/S3ConsumerIntegrationTest.java`.
Please, let me know if this is enough or if possible provide some guidance on how to implement the same tests using localstack. I would expect if I copy and paste the tests from the integration test class to the localstack class would as is.
Another thing is that I didn't is about the java docs, where they are generated and what kind of build I run to generate them? So far I'm run `mvn clean install -Pfastinstall` at the project root to have the build done. However I don't see any java doc being generated. Could you provide guidance here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd closed pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #4274:
URL: https://github.com/apache/camel/pull/4274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4274:
URL: https://github.com/apache/camel/pull/4274#issuecomment-704257689
@avaz any news?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd edited a comment on pull request #4274: CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into the memory
Posted by GitBox <gi...@apache.org>.
oscerd edited a comment on pull request #4274:
URL: https://github.com/apache/camel/pull/4274#issuecomment-706705116
The endpoint is used anyway, so I don't know why in the test with localstack should not be used. Do you have docker running? By the way, the Pr is enough. For the javadoc, you need to do clean install -DskipTests, btw I'll do that once I merge. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org