You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/10/09 21:26:15 UTC
[GitHub] ashb opened a new pull request #4028: [AIRFLOW-3099] Don't ever
warn about missing sections of config
ashb opened a new pull request #4028: [AIRFLOW-3099] Don't ever warn about missing sections of config
URL: https://github.com/apache/incubator-airflow/pull/4028
Make sure you have checked _all_ steps below.
### Jira
- [X] https://issues.apache.org/jira/browse/AIRFLOW-3099
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Rather than looping through and setting each config variable
individually, and having to know which sections are optional and which
aren't, instead we can just call a single function on ConfigParser and
it will read the config from the dict, and more importantly here, never
error about missing sections - it will just create them as needed.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: already covered by existing tests
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services