You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chenliang613 <gi...@git.apache.org> on 2015/08/15 07:15:21 UTC
[GitHub] flink pull request: some small changes for easier understanding.
GitHub user chenliang613 opened a pull request:
https://github.com/apache/flink/pull/1018
some small changes for easier understanding.
some small changes for row 101 for easier understanding.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/flink patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1018.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1018
----
commit b29c9fa8d171018d82df89192327e631f69c88ea
Author: CHEN LIANG <ch...@sina.cn>
Date: 2015-08-15T05:14:46Z
some small changes for easier understanding.
some small changes for row 101 for easier understanding.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: some small changes for easier understanding.
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1018#issuecomment-131756341
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: some small changes for easier understanding.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1018
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: some small changes for easier understanding.
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1018#issuecomment-131583486
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: some small changes for easier understanding.
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1018#discussion_r37133720
--- Diff: docs/apis/cluster_execution.md ---
@@ -98,7 +98,7 @@ The latter version is recommended as it respects the classloader management in F
To provide these dependencies not included by Flink we suggest two options with Maven.
-1. The maven assembly plugin builds a so called fat jar cointaining all your dependencies.
+1. The maven assembly plugin builds a so-called Fat jar(executable jar) containing all your dependencies.
--- End diff --
Prefer to use term uber-jar as mentioned in the maven assembly page [1]
[1] http://maven.apache.org/plugins/maven-assembly-plugin/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---