You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2016/11/07 18:03:26 UTC

[jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/335

-- Commit Summary --

  * Remove duplicated sharedstorage test inputs

-- File Changes --

    D oneandone/src/test/resources/sharedStorage/get.json (24)
    D oneandone/src/test/resources/sharedStorage/list.access.json (24)
    D oneandone/src/test/resources/sharedStorage/list.json (62)
    D oneandone/src/test/resources/sharedStorage/list.options.json (62)
    D oneandone/src/test/resources/sharedStorage/server.get.json (5)
    D oneandone/src/test/resources/sharedStorage/servers.list.json (12)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/335.patch
https://github.com/jclouds/jclouds-labs/pull/335.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/335

Re: [jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

Posted by Andrew Phillips <no...@github.com>.

Thanks for catching this, @andrewgaul! Do we know which of the sets of resources is newer? Or are they identical?

Also, on a separate note, would it be worth sending an email about this to the dev list and/or adding this to the wiki or documentation?

/cc @nacx

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/335#issuecomment-258919465

Re: [jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to master as [cb06b681](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/cb06b681).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/335#issuecomment-259524840

Re: [jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

Posted by Andrew Gaul <no...@github.com>.

`diff -r oneandone/src/test/resources/shared*` confirms that these files are identical.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/335#issuecomment-258985542

Re: [jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

Posted by Andrew Phillips <no...@github.com>.

> diff -r oneandone/src/test/resources/shared* confirms that these files are identical

Thanks, @andrewgaul!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/335#issuecomment-259007172

Re: [jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

Posted by Ignasi Barrera <no...@github.com>.

Closed #335.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/335#event-853580194