[jira] [Comment Edited] (YARN-5408) Compose Federation membership/application/policy APIs into an uber FederationStateStore API

["Subru Krishnan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412301#comment-15412301 ] 

Subru Krishnan edited comment on YARN-5408 at 8/8/16 7:43 PM:
--------------------------------------------------------------

Thanks [~ellenfkh] for the patch. It mostly LGTM, couple of minor comments:
  * Can you rename {{FederationStore}} to {{FederationStateStore}}.
  * Also rename {{getFederationStoreVersion()}} to {{getCurrentVersion()}} and add a {{loadVersion()}} to align with *RMStateStore*.
  * If possible, can you add little more meat to the Javadocs (class/method) of {{FederationStateStore}}.


was (Author: subru):
Thanks [~ellenfkh] for the patch. It mostly LGTM, couple of minor comments:
  * Can you rename {{FederationStore}} to {{FederationStateStore}}.
  * Also rename {{getFederationStoreVersion}} to {{getCurrentVersion}} to align with *RMStateStore*.
  * If possible, can you add little more meat to the Javadocs (class/method) of {{FederationStateStore}}.

> Compose Federation membership/application/policy APIs into an uber FederationStateStore API
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-5408
>                 URL: https://issues.apache.org/jira/browse/YARN-5408
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Ellen Hui
>         Attachments: YARN-5408-YARN-2915.v1.patch
>
>
> This is a simple composition of the three APIs defined in YARN-3664, YARN-5307, YARN-3662. This is for convenience so that we provide a single API for both implementations and for consumers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org