You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/29 08:37:03 UTC

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1320: apps/bleservo: Initial commit.

apache-mynewt-bot commented on PR #1320:
URL: https://github.com/apache/mynewt-nimble/pull/1320#issuecomment-1261953852

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### apps/bleservo/src/gatt_svr.c
   <details>
   
   ```diff
   @@ -82,24 +82,24 @@
            .type = BLE_GATT_SVC_TYPE_PRIMARY,
            .uuid = &gatt_svr_svc_servo_uuid.u,
            .characteristics = (struct ble_gatt_chr_def[]) { {
   -            /* Characteristic: servo angle*/
   -            .uuid = &gatt_svr_chr_servo_angle_uuid.u,
   -            .val_handle = &gatt_angle_val_handle,
   -            .access_cb = gatt_svr_chr_access_servo_angle,
   -            .flags = BLE_GATT_CHR_F_READ |
   -                     BLE_GATT_CHR_F_WRITE |
   -                     BLE_GATT_CHR_F_NOTIFY
   -        }, {
   -            /* Characteristic: servo PWM pulse duration*/
   -            .uuid = &gatt_svr_chr_servo_pulse_duration_uuid.u,
   -            .val_handle = &gatt_pulse_duration_val_handle,
   -            .access_cb = gatt_svr_chr_access_servo_pulse_duration,
   -            .flags = BLE_GATT_CHR_F_READ |
   -                     BLE_GATT_CHR_F_WRITE |
   -                     BLE_GATT_CHR_F_NOTIFY
   -        }, {
   -            0, /* No more characteristics in this service */
   -        }, }
   +                                                             /* Characteristic: servo angle*/
   +                                                             .uuid = &gatt_svr_chr_servo_angle_uuid.u,
   +                                                             .val_handle = &gatt_angle_val_handle,
   +                                                             .access_cb = gatt_svr_chr_access_servo_angle,
   +                                                             .flags = BLE_GATT_CHR_F_READ |
   +                                                                      BLE_GATT_CHR_F_WRITE |
   +                                                                      BLE_GATT_CHR_F_NOTIFY
   +                                                         }, {
   +                                                             /* Characteristic: servo PWM pulse duration*/
   +                                                             .uuid = &gatt_svr_chr_servo_pulse_duration_uuid.u,
   +                                                             .val_handle = &gatt_pulse_duration_val_handle,
   +                                                             .access_cb = gatt_svr_chr_access_servo_pulse_duration,
   +                                                             .flags = BLE_GATT_CHR_F_READ |
   +                                                                      BLE_GATT_CHR_F_WRITE |
   +                                                                      BLE_GATT_CHR_F_NOTIFY
   +                                                         }, {
   +                                                             0, /* No more characteristics in this service */
   +                                                         }, }
        },
    
        {
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org