[GitHub] [incubator-yunikorn-k8shim] adamantal commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag

[GitBox <gi...@apache.org>]

adamantal commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-683840990


   I have validated this patch. Configurations:
   
   Namespace config:
   ```yaml
   apiVersion: v1
   kind: Namespace
   metadata:
     annotations:
       yunikorn.apache.org/parentqueue: "root.special"
     name: random
   ```
   
   The pod:
   ```yaml
   apiVersion: v1
   kind: Pod
   metadata:
     labels:
       app: sleep
       applicationId: "application-sleep-0001"
       namespace: "random"
       queue: "root.default"
     name: task0
   spec:
     schedulerName: yunikorn
     containers:
       - name: sleep-30s
         image: "alpine:latest"
         command: ["sleep", "30"]
         resources:
           requests:
             cpu: "100m"
             memory: "500M"
   ```
   
   Queue configs:
   ```yaml
   partitions:
     - name: default
       placementrules:
         - name: tag
           value: namespace
           create: true
           parent:
             name: tag
             value: "namespace.parentqueue"
             create: true
       queues:
         - name: root
           submitacl: '*'
           queues:
             - name: default
               submitacl: '*'
             - name: special
               parent: true
               submitacl: '*'
               queues:
                 - name: leaf 
   ```
   
   The application was correctly put into queue `root.special.random`.
   
   Note that:
   - the app CRD *has to be turned off* (it is somehow intercepts the basic placement of the application)
   - the Travis CI check is currently failing due to [YUNIKORN-389](https://issues.apache.org/jira/browse/YUNIKORN-389)
   - I also found a scheduler crash during testing, filed [YUNIKORN-390](https://issues.apache.org/jira/browse/YUNIKORN-390) for that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org