You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/09/10 17:40:14 UTC
Review Request 38258: Alerts: HDFS Finalized alert needs to be for
HDFS service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38258/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Vitalyi Brodetskyi.
Bugs: AMBARI-13059
https://issues.apache.org/jira/browse/AMBARI-13059
Repository: ambari
Description
-------
Why is the HDFS finalized alert an ambari server alert? And not HDFS, for the NameNode? Could it be SCRIPT alert, or metric alert on HDFS? Just seems very strange to be on AMbari server, because then it always getting registered, even in clusters w/o HDFS.
{
"href" : "http://server:8080/api/v1/clusters/MyCluster/alert_definitions/40",
"AlertDefinition" : {
"cluster_name" : "MyCluster",
"component_name" : "AMBARI_SERVER",
"description" : "This service-level alert is triggered if HDFS is not in the finalized state",
"enabled" : true,
"id" : 40,
"ignore_host" : false,
"interval" : 10,
"label" : "HDFS Upgrade Finalized State",
"name" : "ambari_upgrade_finalized_state",
"scope" : "SERVICE",
"service_name" : "AMBARI",
"source" : {
"class" : "org.apache.ambari.server.alerts.HDFSUpgradeFinalizedStatusRunnable",
"type" : "SERVER"
}
}
}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnable.java b5da9df
ambari-server/src/main/resources/alerts.json 1285b24
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1310ce8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnableTest.java df9834f
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 86ff0c9
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java 80ab0fe
Diff: https://reviews.apache.org/r/38258/diff/
Testing
-------
----------------------------------------------------------------------
Ran 240 tests in 6.154s
OK
----------------------------------------------------------------------
Total run:793
Total errors:0
Total failures:0
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko
Re: Review Request 38258: Alerts: HDFS Finalized alert needs to be
for HDFS service
Posted by Dmytro Grinenko <ha...@gmail.com>.
> On Sept. 10, 2015, 4:53 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py, line 106
> > <https://reviews.apache.org/r/38258/diff/1/?file=1067194#file1067194line106>
> >
> > Is this needed?
Not realy, patch reattached. Some stringdoc improvements.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38258/#review98420
-----------------------------------------------------------
On Sept. 10, 2015, 5:28 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38258/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 5:28 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13059
> https://issues.apache.org/jira/browse/AMBARI-13059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Why is the HDFS finalized alert an ambari server alert? And not HDFS, for the NameNode? Could it be SCRIPT alert, or metric alert on HDFS? Just seems very strange to be on AMbari server, because then it always getting registered, even in clusters w/o HDFS.
> {
> "href" : "http://server:8080/api/v1/clusters/MyCluster/alert_definitions/40",
> "AlertDefinition" : {
> "cluster_name" : "MyCluster",
> "component_name" : "AMBARI_SERVER",
> "description" : "This service-level alert is triggered if HDFS is not in the finalized state",
> "enabled" : true,
> "id" : 40,
> "ignore_host" : false,
> "interval" : 10,
> "label" : "HDFS Upgrade Finalized State",
> "name" : "ambari_upgrade_finalized_state",
> "scope" : "SERVICE",
> "service_name" : "AMBARI",
> "source" : {
> "class" : "org.apache.ambari.server.alerts.HDFSUpgradeFinalizedStatusRunnable",
> "type" : "SERVER"
> }
> }
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnable.java b5da9df
> ambari-server/src/main/resources/alerts.json 1285b24
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1310ce8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnableTest.java df9834f
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 86ff0c9
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java 80ab0fe
>
> Diff: https://reviews.apache.org/r/38258/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 240 tests in 6.154s
>
> OK
> ----------------------------------------------------------------------
> Total run:793
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 38258: Alerts: HDFS Finalized alert needs to be
for HDFS service
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38258/#review98420
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py (line 106)
<https://reviews.apache.org/r/38258/#comment154897>
Is this needed?
- Sumit Mohanty
On Sept. 10, 2015, 3:40 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38258/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 3:40 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13059
> https://issues.apache.org/jira/browse/AMBARI-13059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Why is the HDFS finalized alert an ambari server alert? And not HDFS, for the NameNode? Could it be SCRIPT alert, or metric alert on HDFS? Just seems very strange to be on AMbari server, because then it always getting registered, even in clusters w/o HDFS.
> {
> "href" : "http://server:8080/api/v1/clusters/MyCluster/alert_definitions/40",
> "AlertDefinition" : {
> "cluster_name" : "MyCluster",
> "component_name" : "AMBARI_SERVER",
> "description" : "This service-level alert is triggered if HDFS is not in the finalized state",
> "enabled" : true,
> "id" : 40,
> "ignore_host" : false,
> "interval" : 10,
> "label" : "HDFS Upgrade Finalized State",
> "name" : "ambari_upgrade_finalized_state",
> "scope" : "SERVICE",
> "service_name" : "AMBARI",
> "source" : {
> "class" : "org.apache.ambari.server.alerts.HDFSUpgradeFinalizedStatusRunnable",
> "type" : "SERVER"
> }
> }
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnable.java b5da9df
> ambari-server/src/main/resources/alerts.json 1285b24
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1310ce8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnableTest.java df9834f
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 86ff0c9
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java 80ab0fe
>
> Diff: https://reviews.apache.org/r/38258/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 240 tests in 6.154s
>
> OK
> ----------------------------------------------------------------------
> Total run:793
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 38258: Alerts: HDFS Finalized alert needs to be
for HDFS service
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38258/#review98457
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 10, 2015, 1:28 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38258/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 1:28 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13059
> https://issues.apache.org/jira/browse/AMBARI-13059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Why is the HDFS finalized alert an ambari server alert? And not HDFS, for the NameNode? Could it be SCRIPT alert, or metric alert on HDFS? Just seems very strange to be on AMbari server, because then it always getting registered, even in clusters w/o HDFS.
> {
> "href" : "http://server:8080/api/v1/clusters/MyCluster/alert_definitions/40",
> "AlertDefinition" : {
> "cluster_name" : "MyCluster",
> "component_name" : "AMBARI_SERVER",
> "description" : "This service-level alert is triggered if HDFS is not in the finalized state",
> "enabled" : true,
> "id" : 40,
> "ignore_host" : false,
> "interval" : 10,
> "label" : "HDFS Upgrade Finalized State",
> "name" : "ambari_upgrade_finalized_state",
> "scope" : "SERVICE",
> "service_name" : "AMBARI",
> "source" : {
> "class" : "org.apache.ambari.server.alerts.HDFSUpgradeFinalizedStatusRunnable",
> "type" : "SERVER"
> }
> }
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnable.java b5da9df
> ambari-server/src/main/resources/alerts.json 1285b24
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1310ce8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnableTest.java df9834f
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 86ff0c9
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java 80ab0fe
>
> Diff: https://reviews.apache.org/r/38258/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 240 tests in 6.154s
>
> OK
> ----------------------------------------------------------------------
> Total run:793
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 38258: Alerts: HDFS Finalized alert needs to be
for HDFS service
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38258/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 5:28 p.m.)
Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Vitalyi Brodetskyi.
Bugs: AMBARI-13059
https://issues.apache.org/jira/browse/AMBARI-13059
Repository: ambari
Description
-------
Why is the HDFS finalized alert an ambari server alert? And not HDFS, for the NameNode? Could it be SCRIPT alert, or metric alert on HDFS? Just seems very strange to be on AMbari server, because then it always getting registered, even in clusters w/o HDFS.
{
"href" : "http://server:8080/api/v1/clusters/MyCluster/alert_definitions/40",
"AlertDefinition" : {
"cluster_name" : "MyCluster",
"component_name" : "AMBARI_SERVER",
"description" : "This service-level alert is triggered if HDFS is not in the finalized state",
"enabled" : true,
"id" : 40,
"ignore_host" : false,
"interval" : 10,
"label" : "HDFS Upgrade Finalized State",
"name" : "ambari_upgrade_finalized_state",
"scope" : "SERVICE",
"service_name" : "AMBARI",
"source" : {
"class" : "org.apache.ambari.server.alerts.HDFSUpgradeFinalizedStatusRunnable",
"type" : "SERVER"
}
}
}
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnable.java b5da9df
ambari-server/src/main/resources/alerts.json 1285b24
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1310ce8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/alerts/HDFSUpgradeFinalizedStatusRunnableTest.java df9834f
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 86ff0c9
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java 80ab0fe
Diff: https://reviews.apache.org/r/38258/diff/
Testing
-------
----------------------------------------------------------------------
Ran 240 tests in 6.154s
OK
----------------------------------------------------------------------
Total run:793
Total errors:0
Total failures:0
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko