[GitHub] [hbase] joshelser commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

[GitBox <gi...@apache.org>]

joshelser commented on pull request #2113:
URL: https://github.com/apache/hbase/pull/2113#issuecomment-671633414


   > If you want to solve the problem automatically, you should find another way to detect the dead region servers when master starts up, to make sure we do not rely on the WAL directories. But I'm still a bit nervous that when SCP notices that there is no WAL directory for a dead region server, what should it do. It is not the expected behavior in HBase...
   
   Am catching up.. but I think Duo's comments here hit on a lot of the worry that I had. How can we be 100% certain that we don't hit this other code-path when we are not in the "cloud recreation" path? Is this better served by HBCK2-type automation which can be run when stuff is being "recreated"? Just thinking out loud.
   
   Making a pass through the code changes you have so far, Stephen. Looks like some good reviews by Anoop already :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org