You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/11/27 11:37:39 UTC

[GitHub] [hbase] frostruan commented on pull request #3716: HBASE-26323 introduce a SnapshotProcedure

frostruan commented on pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#issuecomment-980544930


   Really thanks for taking time review this PR.  I am very happy to see someone still paying attention to this. @Apache9 
   
   Recently I realized that some of my previous ideas are problematic. For example 
   1. The execution of state SNAPSHOT_CONSOLIDATE_SNAPSHOT in SnapshotProcedure is not idempotent. 
   2. If the snapshot is corrupted, the SnapshotVerifyProcedure will get the parent SnapshotPRocedure and mark parent procedure Failed. This may be not ProcedureV2 style (I am not sure, maybe we can implement this in a better way)
   
   I have to say that this work is more complicated than I expected. I should post a design document first and split it into some sub tasks. This PR was submitted a little too early. I will post a design doc as soon as possible. Thanks again. @Apache9 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org