[GitHub] [hive] ArkoSharma commented on a change in pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata

[GitBox <gi...@apache.org>]

ArkoSharma commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r591042930



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -38,7 +38,7 @@
 public class DumpMetaData {
   // wrapper class for reading and writing metadata about a dump
   // responsible for _dumpmetadata files
-  private static final String DUMP_METADATA = "_dumpmetadata";
+  public static final String DUMP_METADATA = "_dumpmetadata";

Review comment:
       The test for this patch (testDumpMetadataBackwardCompatibility) needs to probe on the dumpmetadata file.
   The test works by doing a dump, then deleting newly introduced fields from the dumpmetadata file and then doing a load. This change was made to provide access to the dmd-file name to the test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org