You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/23 04:15:35 UTC

Review Request 12833: Removed unneeded mapping of ID -> executor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12833/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

Removed unneeded mapping of ID -> executor

`framework.executors` and `framework.completed_executors` were arrays
that were converted into maps of ID -> executor, and then the template
called `_.values` to use just the values, i.e. the original executor
arrays, to sort the table.

Stick with the original arrays and save lots of allocation.


Diffs
-----

  src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b 
  src/webui/master/static/slave_framework.html d97684edeb75097bb92e20ca8218a0e3c48e8daa 

Diff: https://reviews.apache.org/r/12833/diff/


Testing
-------


Thanks,

Ross Allen

Re: Review Request 12833: Removed unneeded mapping of ID -> executor

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12833/#review23869
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 23, 2013, 2:15 a.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12833/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:15 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Removed unneeded mapping of ID -> executor
> 
> `framework.executors` and `framework.completed_executors` were arrays
> that were converted into maps of ID -> executor, and then the template
> called `_.values` to use just the values, i.e. the original executor
> arrays, to sort the table.
> 
> Stick with the original arrays and save lots of allocation.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b 
>   src/webui/master/static/slave_framework.html d97684edeb75097bb92e20ca8218a0e3c48e8daa 
> 
> Diff: https://reviews.apache.org/r/12833/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ross Allen
> 
>