You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by bl...@apache.org on 2019/09/04 00:22:34 UTC
[avro] 01/17: AVRO-2454: Fix CA1034 - Nested types should not be
visible
This is an automated email from the ASF dual-hosted git repository.
blachniet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git
commit a1d9b1a64c5c5ca273e5f6dfcf6015a7d1e0cc8f
Author: Brian Lachniet <bl...@gmail.com>
AuthorDate: Sun Aug 18 09:45:59 2019 -0400
AVRO-2454: Fix CA1034 - Nested types should not be visible
---
lang/csharp/Avro.ruleset | 1 -
lang/csharp/src/apache/main/Specific/ObjectCreator.cs | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/lang/csharp/Avro.ruleset b/lang/csharp/Avro.ruleset
index e5a3983..2a101e2 100644
--- a/lang/csharp/Avro.ruleset
+++ b/lang/csharp/Avro.ruleset
@@ -21,7 +21,6 @@
AVRO-2454: We need to evaluate each of these rules to determine whether we should enforce them.
We disabled these rules initially to get the code analyzers installed in the project.
-->
- <Rule Id="CA1034" Action="Info" />
<Rule Id="CA1052" Action="Info" />
<Rule Id="CA1062" Action="Info" />
<Rule Id="CA1063" Action="Info" />
diff --git a/lang/csharp/src/apache/main/Specific/ObjectCreator.cs b/lang/csharp/src/apache/main/Specific/ObjectCreator.cs
index 5c876e5..fe3f6ee 100644
--- a/lang/csharp/src/apache/main/Specific/ObjectCreator.cs
+++ b/lang/csharp/src/apache/main/Specific/ObjectCreator.cs
@@ -74,6 +74,7 @@ namespace Avro.Specific
}
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning disable CA1034 // Nested types should not be visible
/// <summary>
/// Obsolete: This will be removed from the public API in a future version.
/// </summary>
@@ -116,6 +117,7 @@ namespace Avro.Specific
return !left.Equals(right);
}
}
+#pragma warning restore CA1034 // Nested types should not be visible
#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
/// <summary>