You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2014/02/06 02:23:06 UTC

Review Request 17778: FLUME-2312. Add utility for adorning HTTP contexts in Jetty

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17778/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2312
    https://issues.apache.org/jira/browse/FLUME-2312


Repository: flume-git


Description
-------

Blocking out TRACE and OPTIONS HTTP methods. Added tests to ensure that this works as expected.


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 2c2c6f3 
  flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 48c6492 
  flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java a2a1c30 
  flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java ab8ec09 

Diff: https://reviews.apache.org/r/17778/diff/


Testing
-------

Added tests to test this. All of the current tests pass.


Thanks,

Hari Shreedharan


Re: Review Request 17778: FLUME-2312. Add utility for adorning HTTP contexts in Jetty

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17778/#review33751
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Feb. 6, 2014, 1:53 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17778/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 1:53 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2312
>     https://issues.apache.org/jira/browse/FLUME-2312
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Blocking out TRACE and OPTIONS HTTP methods. Added tests to ensure that this works as expected.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 2c2c6f3 
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 48c6492 
>   flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java PRE-CREATION 
>   flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java a2a1c30 
>   flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java ab8ec09 
> 
> Diff: https://reviews.apache.org/r/17778/diff/
> 
> 
> Testing
> -------
> 
> Added tests to test this. All of the current tests pass.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>


Re: Review Request 17778: FLUME-2312. Add utility for adorning HTTP contexts in Jetty

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17778/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 1:53 a.m.)


Review request for Flume.


Bugs: FLUME-2312
    https://issues.apache.org/jira/browse/FLUME-2312


Repository: flume-git


Description
-------

Blocking out TRACE and OPTIONS HTTP methods. Added tests to ensure that this works as expected.


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 2c2c6f3 
  flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 48c6492 
  flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java a2a1c30 
  flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java ab8ec09 

Diff: https://reviews.apache.org/r/17778/diff/


Testing
-------

Added tests to test this. All of the current tests pass.


Thanks,

Hari Shreedharan