You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "fresh-borzoni (via GitHub)" <gi...@apache.org> on 2026/06/10 23:19:14 UTC

[PR] [spark] use CamelCase in config names [fluss]

fresh-borzoni opened a new pull request, #3471:
URL: https://github.com/apache/fluss/pull/3471

   closes https://github.com/apache/fluss/issues/3462
   
   making SparkConfig consistent


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [spark] use CamelCase in config names [fluss]

Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #3471:
URL: https://github.com/apache/fluss/pull/3471#issuecomment-4679907129

   @Yohahaha @YannByron @luoyuxia PTAL 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [spark] use CamelCase in config names [fluss]

Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #3471:
URL: https://github.com/apache/fluss/pull/3471#discussion_r3506630583


##########
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/SparkFlussConf.scala:
##########
@@ -39,21 +39,21 @@ object SparkFlussConf {
 
   val SCAN_START_UP_MODE: ConfigOption[String] =
     ConfigBuilder
-      .key("scan.startup.mode")
+      .key("scanStartupMode")
       .stringType()
       .defaultValue(StartUpMode.FULL.toString)
       .withDescription("The start up mode when read Fluss table.")
 
   val SCAN_POLL_TIMEOUT: ConfigOption[Duration] =
     ConfigBuilder
-      .key("scan.poll.timeout")

Review Comment:
   scan.pollTimeout



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [spark] use CamelCase in config names [fluss]

Posted by "Jackeyzhe (via GitHub)" <gi...@apache.org>.
Jackeyzhe commented on PR #3471:
URL: https://github.com/apache/fluss/pull/3471#issuecomment-4882096848

   One small question: the deprecation path — is there a plan to keep the old snake_case names working with
   a `@Deprecated(since="...")` annotation and a log warning when read, or do you plan a hard 0.x → 0.y cut-off? If the latter, please call out the migration note in the PR description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [spark] use CamelCase in config names [fluss]

Posted by "github-actions[bot] (via GitHub) via issues" <is...@fluss.apache.org>.
github-actions[bot] closed pull request #3471: [spark] use CamelCase in config names
URL: https://github.com/apache/fluss/pull/3471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [spark] use CamelCase in config names [fluss]

Posted by "github-actions[bot] (via GitHub) via issues" <is...@fluss.apache.org>.
github-actions[bot] commented on PR #3471:
URL: https://github.com/apache/fluss/pull/3471#issuecomment-6719347790

   This PR has been marked as stale because it has had no activity for 60 days. It will be closed in 10 days unless it receives a new comment, commit or other update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [spark] use CamelCase in config names [fluss]

Posted by "github-actions[bot] (via GitHub) via issues" <is...@fluss.apache.org>.
github-actions[bot] commented on PR #3471:
URL: https://github.com/apache/fluss/pull/3471#issuecomment-6973406457

   This PR was closed because it has been stale for 10 days with no activity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org