You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/12/03 03:45:17 UTC

[GitHub] [incubator-linkis] wushengyeyouya commented on a change in pull request #1127: Dev 1.1.0-Linkis DataSource

wushengyeyouya commented on a change in pull request #1127:
URL: https://github.com/apache/incubator-linkis/pull/1127#discussion_r761621899



##########
File path: assembly-combined-package/assembly-combined/sbin/ext/linkis-ps-datasourcemanager
##########
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+# description:  datasourcemanager start cmd
+#
+# Modified for Linkis 1.0.0
+
+
+export SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-datasourcemanager"
+
+#export DEBUG_PORT=
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.datasourcemanager.core.LinkisDataSourceManagerApplication

Review comment:
       Please modify it.

##########
File path: assembly-combined-package/assembly-combined/sbin/ext/linkis-ps-metadatamanager-hive
##########
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+# description:  metadatamanager-hive start cmd
+#
+# Modified for Linkis 1.0.0
+
+
+export SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-hive"
+
+#export DEBUG_PORT=
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerHiveApplication

Review comment:
       Please modify it.

##########
File path: assembly-combined-package/assembly-combined/sbin/ext/linkis-ps-metadatamanager-kafka
##########
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+# description:  metadatamanager-kafka start cmd
+#
+# Modified for Linkis 1.0.0
+
+
+export SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-kafka"
+
+#export DEBUG_PORT=
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerKafkaApplication

Review comment:
       Please modify it.

##########
File path: .gitignore
##########
@@ -81,15 +78,6 @@ linkis-public-enhancements/linkis-publicService/linkis-script-dev/linkis-storage
 linkis-public-enhancements/linkis-publicService/linkis-udf/target/
 linkis-public-enhancements/linkis-publicService/linkis-variable/target/
 linkis-public-enhancements/linkis-publicService/target/
-linkis-public-enhancements/linkis-publicservice/linkis-error-code/linkis-error-code-client/target/
-linkis-public-enhancements/linkis-publicservice/linkis-error-code/linkis-error-code-common/target/
-linkis-public-enhancements/linkis-publicservice/linkis-error-code/linkis-error-code-server/target/
-linkis-public-enhancements/linkis-publicservice/linkis-instance-label/linkis-instance-label-client/target/
-linkis-public-enhancements/linkis-publicservice/linkis-instance-label/linkis-instance-label-server/target/
-linkis-public-enhancements/linkis-publicservice/linkis-udf/linkis-udf-client/target/
-linkis-public-enhancements/linkis-publicservice/linkis-udf/linkis-udf-common/target/

Review comment:
       Why delete those gitignores?

##########
File path: assembly-combined-package/assembly-combined/sbin/ext/linkis-ps-metadatamanager
##########
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+# description:  metadatamanager start cmd
+#
+# Modified for Linkis 1.0.0
+
+
+export SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager"
+
+#export DEBUG_PORT=
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.server.LinkisMetadataManagerApplication

Review comment:
       Please modify it.

##########
File path: assembly-combined-package/assembly-combined/sbin/ext/linkis-ps-metadatamanager-es
##########
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+# description:  metadatamanager-es start cmd
+#
+# Modified for Linkis 1.0.0
+
+
+export SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-es"
+
+#export DEBUG_PORT=
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerEsApplication

Review comment:
       Please modify it.

##########
File path: assembly-combined-package/assembly-combined/conf/linkis-ps-metadatamanager.properties
##########
@@ -13,27 +14,18 @@
 # limitations under the License.
 #
 
-server:
-  port: 8196
-spring:
-  application:
-    name: linkis-ps-datasourcemanager
-
-eureka:
-  client:
-    serviceUrl:
-      defaultZone: http://${ip}:${port}/eureka/
-  instance:
-    metadata-map:
-      test: linkis
-
-management:
-  endpoints:
-    web:
-      exposure:
-        include: refresh,info
-logging:
-  config: classpath:log4j2.xml
+wds.linkis.server.mybatis.mapperLocations=
+wds.linkis.server.mybatis.typeAliasesPackage=
+wds.linkis.server.mybatis.BasePackage=
+wds.linkis.server.restful.scan.packages=com.webank.wedatasphere.linkis.metadatamanager.server.restful
 
+#sit
+wds.linkis.server.version=v1
+wds.linkis.server.mybatis.datasource.url=
+wds.linkis.server.mybatis.datasource.username=
+wds.linkis.server.mybatis.datasource.password=
 
+#test
+wds.linkis.test.mode=true
+wds.linkis.test.user=davidhua

Review comment:
       Please modify it.

##########
File path: assembly-combined-package/assembly-combined/sbin/linkis-start-all.sh
##########
@@ -90,6 +90,35 @@ SERVER_NAME="ps-cs"
 SERVER_IP=$CS_INSTALL_IP
 startApp
 
+#datasourcemanager
+SERVER_NAME="ps-datasourcemanager"
+SERVER_IP=$DATASOURCEMANAGER_INSTALL_IP
+startApp
+
+#metadatamanager
+SERVER_NAME="ps-metadatamanager"
+SERVER_IP=$METADATAMANAGER_INSTALL_IP
+startApp
+
+#metadatamanager-es
+SERVER_NAME="ps-metadatamanager-es"
+SERVER_IP=$METADATAMANAGER_ES_INSTALL_IP
+startApp
+
+#metadatamanager-hive
+SERVER_NAME="ps-metadatamanager-hive"
+SERVER_IP=$METADATAMANAGER_HIVE_INSTALL_IP
+startApp
+
+#metadatamanager-kafka
+SERVER_NAME="ps-metadatamanager-kafka"
+SERVER_IP=$METADATAMANAGER_KAFKA_INSTALL_IP
+startApp

Review comment:
       So many DataSource process, I suggest create a new start DataSources script to start it.

##########
File path: assembly-combined-package/assembly-combined/sbin/linkis-stop-all.sh
##########
@@ -86,6 +86,37 @@ SERVER_NAME="ps-publicservice"
 SERVER_IP=$PUBLICSERVICE_INSTALL_IP
 stopApp
 
+#datasourcemanager
+SERVER_NAME="ps-datasourcemanager"
+SERVER_IP=$DATASOURCEMANAGER_INSTALL_IP
+stopApp
+
+#metadatamanager
+SERVER_NAME="ps-metadatamanager"
+SERVER_IP=$METADATAMANAGER_INSTALL_IP
+stopApp
+
+#metadatamanager-es
+SERVER_NAME="ps-metadatamanager-es"
+SERVER_IP=$METADATAMANAGER_ES_INSTALL_IP
+stopApp
+
+#metadatamanager-hive
+SERVER_NAME="ps-metadatamanager-hive"
+SERVER_IP=$METADATAMANAGER_HIVE_INSTALL_IP
+stopApp
+
+#metadatamanager-kafka
+SERVER_NAME="ps-metadatamanager-kafka"
+SERVER_IP=$METADATAMANAGER_KAFKA_INSTALL_IP
+stopApp
+
+#metadatamanager-mysql
+SERVER_NAME="ps-metadatamanager-mysql"
+SERVER_IP=$METADATAMANAGER_MYSQL_INSTALL_IP
+stopApp

Review comment:
       So many DataSource process, I suggest create a new stop DataSources script to stop it.

##########
File path: linkis-commons/linkis-module/src/main/java/org/apache/linkis/DataWorkCloudApplication.java
##########
@@ -67,7 +67,7 @@
 @SpringBootApplication
 @EnableDiscoveryClient
 @RefreshScope
-@ComponentScan(basePackages = {"org.apache.linkis","com.webank.wedatasphere"},

Review comment:
       Cannot delete it.

##########
File path: assembly-combined-package/assembly-combined/sbin/ext/linkis-ps-metadatamanager-mysql
##########
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+# description:  metadatamanager-mysql start cmd
+#
+# Modified for Linkis 1.0.0
+
+
+export SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-mysql"
+
+#export DEBUG_PORT=
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerMysqlApplication

Review comment:
       Please modify it.

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/exception/DataSourceClientBuilderException.scala
##########
@@ -0,0 +1,5 @@
+package org.apache.linkis.datasource.client.exception

Review comment:
       License is needed.

##########
File path: db/linkis_dml.sql
##########
@@ -235,86 +235,120 @@ INNER JOIN linkis_cg_manager_label label ON relation.engine_type_label_id = labe
 insert  into `linkis_cg_rm_external_resource_provider`(`id`,`resource_type`,`name`,`labels`,`config`) values
 (1,'Yarn','sit',NULL,'{\r\n\"rmWebAddress\": \"@YARN_RESTFUL_URL\",\r\n\"hadoopVersion\": \"2.7.2\",\r\n\"authorEnable\":false,\r\n\"user\":\"hadoop\",\r\n\"pwd\":\"123456\"\r\n}');
 
--- errorcode 
 INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('10001','会话创建失败,%s队列不存在,请检查队列设置是否正确','queue (\\S+) is not exists in YARN',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('10001','会话创建失败,用户%s不能提交应用到队列:%s,请联系提供队列给您的人员','User (\\S+) cannot submit applications to queue (\\S+)',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('20001','Session创建失败,当前申请资源%s,队列可用资源%s,请检查资源配置是否合理','您本次向任务队列([a-zA-Z_0-9\\.]+)请求资源((.+)),任务队列最大可用资源(.+),任务队列剩余可用资源((.+))您已占用任务队列资源(.+)',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('20002','Session创建失败,服务器资源不足,请稍后再试','远程服务器没有足够资源实例化[a-zA-Z]+ Session,通常是由于您设置【驱动内存】或【客户端内存】过高导致的,建议kill脚本,调低参数后重新提交!等待下次调度...',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('20003','Session创建失败,队列资源不足,请稍后再试','request resources from ResourceManager has reached 560++ tries, give up and mark it as FAILED.',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('20003','文件%s不存在','Caused by:\\s*java.io.FileNotFoundException',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('20083','Java进程内存溢出,建议优化脚本内容','OutOfMemoryError',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('30001','%s无权限访问,请申请开通数据表权限,请联系您的数据管理人员','Permission denied:\\s*user=[a-zA-Z0-9_]+,\\s*access=[A-Z]+\\s*,\\s*inode="([a-zA-Z0-9/_\\.]+)"',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40001','数据库%s不存在,请检查引用的数据库是否有误','Database ''([a-zA-Z_0-9]+)'' not found',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40001','数据库%s不存在,请检查引用的数据库是否有误','Database does not exist: ([a-zA-Z_0-9]+)',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40002','表%s不存在,请检查引用的表是否有误','Table or view not found: ([`\\.a-zA-Z_0-9]+)',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40002','表%s不存在,请检查引用的表是否有误','Table not found ''([a-zA-Z_0-9]+)''',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40003','字段%s不存在,请检查引用的字段是否有误','cannot resolve ''`(.+)`'' given input columns',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40003','字段%s不存在,请检查引用的字段是否有误',' Invalid table alias or column reference ''(.+)'':',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40004','分区字段%s不存在,请检查引用的表%s是否为分区表或分区字段有误','([a-zA-Z_0-9]+) is not a valid partition column in table ([`\\.a-zA-Z_0-9]+)',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40004','分区字段%s不存在,请检查引用的表是否为分区表或分区字段有误','Partition spec \\{(\\S+)\\} contains non-partition columns',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40004','分区字段%s不存在,请检查引用的表是否为分区表或分区字段有误','table is not partitioned but partition spec exists:\\{(.+)\\}',0);
-INSERT INTO linkis_ps_error_code (error_code,error_desc,error_regex,error_type) VALUES ('40004','表对应的路径不存在,请联系您的数据管理人员','Path does not exist: viewfs',0);

Review comment:
       Why delete it?

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/DataSourceRemoteClient.scala
##########
@@ -0,0 +1,13 @@
+package org.apache.linkis.datasource.client

Review comment:
       License is needed.

##########
File path: sbin/ext/linkis-ps-datasourcemanager
##########
@@ -0,0 +1,73 @@
+#!/bin/bash
+#
+# description:  datasource start cmd
+# @created:     06.04.2021
+#
+# Modified for Linkis 1.0.0
+
+# get log directory
+
+source $LINKIS_CONF_DIR/linkis-env.sh
+SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-datasourcemanager"
+## set log
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="$LINKIS_HOME/logs"
+fi
+export SERVER_LOG_PATH=$LINKIS_LOG_DIR/$SERVER_SUFFIX
+if [ ! -w "$SERVER_LOG_PATH" ] ; then
+  mkdir -p "$SERVER_LOG_PATH"
+fi
+
+if test -z "$SERVER_HEAP_SIZE"
+then
+  export SERVER_HEAP_SIZE="512M"
+fi
+
+if test -z "$SERVER_JAVA_OPTS"
+then
+  export SERVER_JAVA_OPTS=" -Xmx$SERVER_HEAP_SIZE -XX:+UseG1GC -Xloggc:$SERVER_LOG_PATH/linkis-gc.log"
+fi
+
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.datasourcemanager.core.LinkisDataSourceManagerApplication

Review comment:
       Please modify it.

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/MetaDataRemoteClient.scala
##########
@@ -0,0 +1,12 @@
+package org.apache.linkis.datasource.client

Review comment:
       License is needed.

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/impl/LinkisDataSourceRemoteClient.scala
##########
@@ -0,0 +1,24 @@
+package org.apache.linkis.datasource.client.impl

Review comment:
       License is needed.

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/request/GetAllDataSourceTypesAction.scala
##########
@@ -0,0 +1,33 @@
+package org.apache.linkis.datasource.client.request

Review comment:
       License is needed.

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/impl/LinkisMetaDataRemoteClient.scala
##########
@@ -0,0 +1,21 @@
+package org.apache.linkis.datasource.client.impl

Review comment:
       License is needed.

##########
File path: sbin/ext/linkis-ps-metadatamanager
##########
@@ -0,0 +1,73 @@
+#!/bin/bash
+#
+# description:  metadata start cmd
+# @created:     06.07.2021
+#
+# Modified for Linkis 1.0.0
+
+# get log directory
+
+source $LINKIS_CONF_DIR/linkis-env.sh
+SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager"
+## set log
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="$LINKIS_HOME/logs"
+fi
+export SERVER_LOG_PATH=$LINKIS_LOG_DIR/$SERVER_SUFFIX
+if [ ! -w "$SERVER_LOG_PATH" ] ; then
+  mkdir -p "$SERVER_LOG_PATH"
+fi
+
+if test -z "$SERVER_HEAP_SIZE"
+then
+  export SERVER_HEAP_SIZE="512M"
+fi
+
+if test -z "$SERVER_JAVA_OPTS"
+then
+  export SERVER_JAVA_OPTS=" -Xmx$SERVER_HEAP_SIZE -XX:+UseG1GC -Xloggc:$SERVER_LOG_PATH/linkis-gc.log"
+fi
+
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.server.LinkisMetadataManagerApplication

Review comment:
       Please modify it.

##########
File path: sbin/ext/linkis-ps-metadatamanager-kafka
##########
@@ -0,0 +1,73 @@
+#!/bin/bash
+#
+# description:  metadata-kafka start cmd
+# @created:     06.07.2021
+#
+# Modified for Linkis 1.0.0
+
+# get log directory
+
+source $LINKIS_CONF_DIR/linkis-env.sh
+SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-kafka"
+## set log
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="$LINKIS_HOME/logs"
+fi
+export SERVER_LOG_PATH=$LINKIS_LOG_DIR/$SERVER_SUFFIX
+if [ ! -w "$SERVER_LOG_PATH" ] ; then
+  mkdir -p "$SERVER_LOG_PATH"
+fi
+
+if test -z "$SERVER_HEAP_SIZE"
+then
+  export SERVER_HEAP_SIZE="512M"
+fi
+
+if test -z "$SERVER_JAVA_OPTS"
+then
+  export SERVER_JAVA_OPTS=" -Xmx$SERVER_HEAP_SIZE -XX:+UseG1GC -Xloggc:$SERVER_LOG_PATH/linkis-gc.log"
+fi
+
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerKafkaApplication

Review comment:
       Please modify it.

##########
File path: sbin/ext/linkis-ps-metadatamanager-es
##########
@@ -0,0 +1,73 @@
+#!/bin/bash
+#
+# description:  metadata-es start cmd
+# @created:     06.07.2021
+#
+# Modified for Linkis 1.0.0
+
+# get log directory
+
+source $LINKIS_CONF_DIR/linkis-env.sh
+SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-es"
+## set log
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="$LINKIS_HOME/logs"
+fi
+export SERVER_LOG_PATH=$LINKIS_LOG_DIR/$SERVER_SUFFIX
+if [ ! -w "$SERVER_LOG_PATH" ] ; then
+  mkdir -p "$SERVER_LOG_PATH"
+fi
+
+if test -z "$SERVER_HEAP_SIZE"
+then
+  export SERVER_HEAP_SIZE="512M"
+fi
+
+if test -z "$SERVER_JAVA_OPTS"
+then
+  export SERVER_JAVA_OPTS=" -Xmx$SERVER_HEAP_SIZE -XX:+UseG1GC -Xloggc:$SERVER_LOG_PATH/linkis-gc.log"
+fi
+
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerEsApplication

Review comment:
       Please modify it.

##########
File path: linkis-public-enhancements/linkis-datasource/datasource-client/src/main/scala/org/apache/linkis/datasource/client/RemoteClient.scala
##########
@@ -0,0 +1,12 @@
+package org.apache.linkis.datasource.client

Review comment:
       License is needed.

##########
File path: sbin/ext/linkis-ps-metadatamanager-hive
##########
@@ -0,0 +1,73 @@
+#!/bin/bash
+#
+# description:  metadata-hive start cmd
+# @created:     06.07.2021
+#
+# Modified for Linkis 1.0.0
+
+# get log directory
+
+source $LINKIS_CONF_DIR/linkis-env.sh
+SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-hive"
+## set log
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="$LINKIS_HOME/logs"
+fi
+export SERVER_LOG_PATH=$LINKIS_LOG_DIR/$SERVER_SUFFIX
+if [ ! -w "$SERVER_LOG_PATH" ] ; then
+  mkdir -p "$SERVER_LOG_PATH"
+fi
+
+if test -z "$SERVER_HEAP_SIZE"
+then
+  export SERVER_HEAP_SIZE="512M"
+fi
+
+if test -z "$SERVER_JAVA_OPTS"
+then
+  export SERVER_JAVA_OPTS=" -Xmx$SERVER_HEAP_SIZE -XX:+UseG1GC -Xloggc:$SERVER_LOG_PATH/linkis-gc.log"
+fi
+
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerHiveApplication

Review comment:
       Please modify it.

##########
File path: sbin/ext/linkis-ps-metadatamanager-mysql
##########
@@ -0,0 +1,73 @@
+#!/bin/bash
+#
+# description:  metadata-mysql start cmd
+# @created:     06.07.2021
+#
+# Modified for Linkis 1.0.0
+
+# get log directory
+
+source $LINKIS_CONF_DIR/linkis-env.sh
+SERVER_SUFFIX="linkis-public-enhancements/linkis-ps-metadatamanager-mysql"
+## set log
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="$LINKIS_HOME/logs"
+fi
+export SERVER_LOG_PATH=$LINKIS_LOG_DIR/$SERVER_SUFFIX
+if [ ! -w "$SERVER_LOG_PATH" ] ; then
+  mkdir -p "$SERVER_LOG_PATH"
+fi
+
+if test -z "$SERVER_HEAP_SIZE"
+then
+  export SERVER_HEAP_SIZE="512M"
+fi
+
+if test -z "$SERVER_JAVA_OPTS"
+then
+  export SERVER_JAVA_OPTS=" -Xmx$SERVER_HEAP_SIZE -XX:+UseG1GC -Xloggc:$SERVER_LOG_PATH/linkis-gc.log"
+fi
+
+
+export SERVER_CLASS=com.webank.wedatasphere.linkis.metadatamanager.LinkisMetadataManagerMysqlApplication

Review comment:
       Please modify it.

##########
File path: linkis-public-enhancements/linkis-datasource/metadatamanager/service/hive/pom.xml
##########
@@ -130,7 +136,7 @@
         </executions>
         <configuration>
           <skipAssembly>false</skipAssembly>
-          <finalName>linkis-mdm-service-hive</finalName>
+          <finalName>out</finalName>

Review comment:
       Please modify it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org