[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

[GitBox <gi...@apache.org>]

imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs
URL: https://github.com/apache/spark/pull/25926#discussion_r331838218
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
 ##########
 @@ -152,32 +155,27 @@ class GBTClassifier @Since("1.4.0") (
     set(validationIndicatorCol, value)
   }
 
+  /**
+   * Sets the value of param [[weightCol]].
+   * If this is not set or empty, we treat all instance weights as 1.0.
+   * Default is not set, so all instances have weight one.
+   *
+   * @group setParam
+   */
+  @Since("3.0.0")
+  def setWeightCol(value: String): this.type = set(weightCol, value)
+
   override protected def train(
       dataset: Dataset[_]): GBTClassificationModel = instrumented { instr =>
-    val categoricalFeatures: Map[Int, Int] =
-      MetadataUtils.getCategoricalFeatures(dataset.schema($(featuresCol)))
+    val categoricalFeatures = MetadataUtils.getCategoricalFeatures(dataset.schema($(featuresCol)))
 
 Review comment:
   probably good to move boostingStrategy below as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org