[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

["Munendra S N (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985848#comment-16985848 ] 

Munendra S N commented on SOLR-7798:
------------------------------------

Thanks [~mgibney] for the ping and pr. I will look into this

> Improve robustness of ExpandComponent
> -------------------------------------
>
>                 Key: SOLR-7798
>                 URL: https://issues.apache.org/jira/browse/SOLR-7798
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Jörg Rathlev
>            Assignee: Joel Bernstein
>            Priority: Minor
>         Attachments: expand-component.patch, expand-npe.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{ExpandComponent}} causes a {{NullPointerException}} if accidentally used without prior collapsing of results.
> If there are multiple documents in the result which have the same term value in the expand field, the size of the {{ordBytes}}/{{groupSet}} differs from the {{count}} value, and the {{getGroupQuery}} method creates an incompletely filled {{bytesRef}} array, which later causes a {{NullPointerException}} when trying to sort the terms.
> The attached patch extends the test to demonstrate the error, and modifies the {{getGroupQuery}} methods to create the array based on the size of the input maps.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org