You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/27 05:20:32 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #2582: fix sync bug for tsfiles's directory changed by vitural storage group

HTHou commented on a change in pull request #2582:
URL: https://github.com/apache/iotdb/pull/2582#discussion_r565035375



##########
File path: server/src/main/java/org/apache/iotdb/db/sync/sender/manage/SyncFileManager.java
##########
@@ -47,33 +47,35 @@
 
   /**
    * All storage groups on the disk where the current sync task is executed
+   * logicalSg -> <virtualSg, timeRangeId>
    */
-  private Map<String, Set<Long>> allSGs;
+  private Map<String, Map<Long, Set<Long>>> allSGs;
 
   /**
    * Key is storage group, value is all sealed tsfiles in the storage group. Inner key is time range
    * id, inner value is the set of current sealed tsfiles.
+   * logicalSg -> virtualSg ->  <timeRangeId, files>
    */
-  private Map<String, Map<Long, Set<File>>> currentSealedLocalFilesMap;
+  private Map<String, Map<Long, Map<Long, Set<File>>>> currentSealedLocalFilesMap;
 
   /**
    * Key is storage group, value is all last local tsfiles in the storage group, which doesn't
    * contains those tsfiles which are not synced successfully. Inner key is time range id, inner
    * value is the set of last local tsfiles.

Review comment:
       Update these comments?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org