[GitHub] dpogue commented on a change in pull request #344: CB-13290: (ios) Update splash screen mapping for missing devices

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #344: CB-13290: (ios) Update splash screen mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#discussion_r146691180
 
 

 ##########
 File path: bin/templates/scripts/cordova/lib/prepare.js
 ##########
 @@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens, splashScreensDir) {
         {dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
         {dest: 'Default-667h.png', width: 750, height: 1334},
         {dest: 'Default-736h.png', width: 1242, height: 2208},
-        {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+        {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+        {dest: 'Default-2436h.png', width: 1125, height: 2436},
+        {dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
 
 Review comment:
   This seems to be missing 1668?2224 (and landscape) & 2048?2732 (and landscape) for larger iPad Pro devices.
   
   We really should be encouraging Launch Storyboards for those, but if it's as easy as adding more numbers here then it would be nice to support them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org