[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3679: Add ledgerDir to GarbageCollectionStatus

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #3679:
URL: https://github.com/apache/bookkeeper/pull/3679#discussion_r1134735869


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/TestHttpService.java:
##########
@@ -832,6 +833,7 @@ public void testGCDetailsService() throws Exception {
         HttpServiceRequest request1 = new HttpServiceRequest(null, HttpServer.Method.GET, null);
         HttpServiceResponse response1 = gcDetailsService.handle(request1);
         assertEquals(HttpServer.StatusCode.OK.getValue(), response1.getStatusCode());
+        assertTrue(JsonUtil.fromJson(response1.getBody(), List.class).get(0).toString().contains("ledgerDir"));

Review Comment:
   Please add a detailed unit test for DbLedgerStorage, InterleavedLedgerStorage, and SortedLedgerStorage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org