[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #3423: HDDS-6280. Support Container Balancer HA

[GitBox <gi...@apache.org>]

siddhantsangwan commented on code in PR #3423:
URL: https://github.com/apache/ozone/pull/3423#discussion_r886571635


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/ByteStringCodec.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.scm.ha.io;
+
+import com.google.protobuf.ByteString;
+import com.google.protobuf.InvalidProtocolBufferException;
+
+/**
+ * A dummy codec that serializes a ByteString object to ByteString.
+ */
+public class ByteStringCodec implements Codec {

Review Comment:
   `encode()` in `SCMRatisRequest` requires a codec to be present in `CodecFactory` that converts an Object to ByteString:
   
   ```
         final MethodArgument.Builder argBuilder = MethodArgument.newBuilder();
         // Set actual method parameter type, not actual argument type.
         // This is done to avoid MethodNotFoundException in case if argument is
         // subclass type, where as method is defined with super class type.
         argBuilder.setType(parameterTypes[paramCounter++].getName());
         argBuilder.setValue(CodecFactory.getCodec(argument.getClass())
             .serialize(argument));
         args.add(argBuilder.build());
   
   ```
   The existing `ByteStringCodec` class encodes a ByteString to a byte array and vice-versa. That's why I had to introduce this dummy class. I thought this would be simpler than making changes to `encode()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org