You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/12/08 14:21:40 UTC
[GitHub] [sling-org-apache-sling-hapi-client] rombert commented on a change in pull request #1: update dependencies to current ones
rombert commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-hapi-client/pull/1#discussion_r764905121
##########
File path: pom.xml
##########
@@ -41,7 +41,7 @@
</scm>
<properties>
- <sling.java.version>6</sling.java.version>
+ <sling.java.version>8</sling.java.version>
Review comment:
Please update the bundle version to 1.1.0-SNAPSHOT, since we are now changing the base requirements.
##########
File path: pom.xml
##########
@@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.sling</groupId>
<artifactId>sling</artifactId>
- <version>30</version>
+ <version>39</version>
Review comment:
Any reason to not use the latest parent pom?
```suggestion
<version>45</version>
```
##########
File path: pom.xml
##########
@@ -69,41 +69,47 @@
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.1</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpmime</artifactId>
- <version>4.5</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>commons-lang</groupId>
- <artifactId>commons-lang</artifactId>
- <version>2.5</version>
+ <groupId>org.apache.commons</groupId>
Review comment:
It looks like commons-lang is not used at all, can you please remove it?
##########
File path: pom.xml
##########
@@ -69,41 +69,47 @@
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.1</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpmime</artifactId>
- <version>4.5</version>
+ <version>4.5.13</version>
Review comment:
This dependency is used only to calculate the OSGi package import ranges, please keep using the oldest one that works.
##########
File path: pom.xml
##########
@@ -69,41 +69,47 @@
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.1</version>
+ <version>4.5.13</version>
Review comment:
This dependency is used only to calculate the OSGi package import ranges, please keep using the oldest one that works.
##########
File path: pom.xml
##########
@@ -69,41 +69,47 @@
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.1</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpmime</artifactId>
- <version>4.5</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>commons-lang</groupId>
- <artifactId>commons-lang</artifactId>
- <version>2.5</version>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.12.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.5</version>
+ <version>2.11.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.jsoup</groupId>
<artifactId>jsoup</artifactId>
- <version>1.9.2</version>
+ <version>1.14.3</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.service.component.annotations</artifactId>
+ <version>1.5.0</version>
+ <scope>provided</scope>
+ </dependency>
<!-- test scope -->
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.1</version>
+ <version>4.5.13</version>
Review comment:
Technically speaking this one is used only for tests, but since we already declare it with scope=provided we need to keep the same version. So please don't change this one either. But maybe it's worth extracting a `httpclient.version` property since we already use it so many times.
##########
File path: pom.xml
##########
@@ -69,41 +69,47 @@
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.1</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpmime</artifactId>
- <version>4.5</version>
+ <version>4.5.13</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>commons-lang</groupId>
- <artifactId>commons-lang</artifactId>
- <version>2.5</version>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.12.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.5</version>
+ <version>2.11.0</version>
Review comment:
This dependency is used only to calculate the OSGi package import ranges, please keep using the oldest one that works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org