You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/12/10 07:55:55 UTC
[PR] OPENNLP-1525 Improve TokenizerME to make use of abbreviations provided in TokenizerModel (opennlp)
mawiesne opened a new pull request, #562:
URL: https://github.com/apache/opennlp/pull/562
Change
-
- enhances TokenizerME impl to make use of abbreviations if available in TokenizerModel
- adjusts expectation in TokenizerFactoryTest#testCustomPatternForTokenizerMEDeu to 14 tokens
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1525 Improve TokenizerME to make use of abbreviations provided in TokenizerModel (opennlp)
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #562:
URL: https://github.com/apache/opennlp/pull/562#issuecomment-1848886979
FYI @l-ma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1525 Improve TokenizerME to make use of abbreviations provided in TokenizerModel (opennlp)
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on code in PR #562:
URL: https://github.com/apache/opennlp/pull/562#discussion_r1422554680
##########
opennlp-tools/src/main/java/opennlp/tools/tokenize/TokenizerME.java:
##########
@@ -258,4 +274,24 @@ public boolean useAlphaNumericOptimization() {
return useAlphaNumericOptimization;
}
+ /**
+ * Allows checking a token abbreviation candidate for acceptability.
+ *
+ * <p>Note: The implementation always returns {@code false} if no
+ * abbreviation dictionary is available for the underlying model.</p>
+ *
+ * @param s the {@link CharSequence} in which the break occurred.
+ * @return {@code true} if the candidate is acceptable, {@code false} otherwise.
+ */
+ protected boolean isAcceptableAbbreviation(CharSequence s) {
+ if (abbDict == null)
+ return false;
+
+ for (String abb : abbDict.asStringSet()) {
Review Comment:
Thx @jzonthemtn for the pointer. It can be used to keep the code cleaner. Will push an improved version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1525 Improve TokenizerME to make use of abbreviations provided in TokenizerModel (opennlp)
Posted by "jzonthemtn (via GitHub)" <gi...@apache.org>.
jzonthemtn commented on code in PR #562:
URL: https://github.com/apache/opennlp/pull/562#discussion_r1422515206
##########
opennlp-tools/src/main/java/opennlp/tools/tokenize/TokenizerME.java:
##########
@@ -258,4 +274,24 @@ public boolean useAlphaNumericOptimization() {
return useAlphaNumericOptimization;
}
+ /**
+ * Allows checking a token abbreviation candidate for acceptability.
+ *
+ * <p>Note: The implementation always returns {@code false} if no
+ * abbreviation dictionary is available for the underlying model.</p>
+ *
+ * @param s the {@link CharSequence} in which the break occurred.
+ * @return {@code true} if the candidate is acceptable, {@code false} otherwise.
+ */
+ protected boolean isAcceptableAbbreviation(CharSequence s) {
+ if (abbDict == null)
+ return false;
+
+ for (String abb : abbDict.asStringSet()) {
Review Comment:
I think `Dictionary` has a `contains()` but I don't know if it works how you need it to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1525 Improve TokenizerME to make use of abbreviations provided in TokenizerModel (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #562:
URL: https://github.com/apache/opennlp/pull/562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org