You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/09 09:44:20 UTC

[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #7894: doc: update install and get started link in readme.md

monkeyDluffy6017 opened a new pull request, #7894:
URL: https://github.com/apache/apisix/pull/7894

   ### Description
   
   In the documentation's [get-started](https://github.com/apache/apisix#get-started) part, links of [install documentation](https://github.com/apache/apisix/blob/master/docs/en/latest/installation-guide.md) and [Getting Started](https://github.com/apache/apisix/blob/master/docs/en/latest/getting-started.md) are hard to read(guess due to the JSX part in MD file is not properly rendered)
   
   Fixes #7831
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7894: doc: update install and get started link in readme.md

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7894:
URL: https://github.com/apache/apisix/pull/7894#discussion_r966869322


##########
docs/zh/latest/README.md:
##########
@@ -167,11 +167,11 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、
 
 1. 安装
 
-   请参考[APISIX 安装指南](./installation-guide.md)。
+   请参考[APISIX 安装指南](https://apisix.apache.org/docs/apisix/installation-guide/)。
 
 2. 入门指南
 
-   入门指南是学习 APISIX 基础知识的好方法。按照 [入门指南](getting-started.md)的步骤即可。
+   入门指南是学习 APISIX 基础知识的好方法。按照 [入门指南](https://apisix.apache.org/docs/apisix/getting-started/)的步骤即可。

Review Comment:
   ```suggestion
      入门指南是学习 APISIX 基础知识的好方法。按照 [入门指南](https://apisix.apache.org/zh/docs/apisix/getting-started/)的步骤即可。
   ```



##########
docs/zh/latest/README.md:
##########
@@ -167,11 +167,11 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、
 
 1. 安装
 
-   请参考[APISIX 安装指南](./installation-guide.md)。
+   请参考[APISIX 安装指南](https://apisix.apache.org/docs/apisix/installation-guide/)。

Review Comment:
   ```suggestion
      请参考[APISIX 安装指南](https://apisix.apache.org/zh/docs/apisix/installation-guide/)。
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] SylviaBABY merged pull request #7894: docs: update install and get started link in readme.md

Posted by GitBox <gi...@apache.org>.
SylviaBABY merged PR #7894:
URL: https://github.com/apache/apisix/pull/7894


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #7894: docs: update install and get started link in readme.md

Posted by GitBox <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #7894:
URL: https://github.com/apache/apisix/pull/7894#discussion_r969069847


##########
docs/zh/latest/README.md:
##########
@@ -167,11 +167,11 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、
 
 1. 安装
 
-   请参考[APISIX 安装指南](./installation-guide.md)。
+   请参考[APISIX 安装指南](https://apisix.apache.org/docs/apisix/installation-guide/)。
 
 2. 入门指南
 
-   入门指南是学习 APISIX 基础知识的好方法。按照 [入门指南](getting-started.md)的步骤即可。
+   入门指南是学习 APISIX 基础知识的好方法。按照 [入门指南](https://apisix.apache.org/docs/apisix/getting-started/)的步骤即可。

Review Comment:
   Done



##########
docs/zh/latest/README.md:
##########
@@ -167,11 +167,11 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、
 
 1. 安装
 
-   请参考[APISIX 安装指南](./installation-guide.md)。
+   请参考[APISIX 安装指南](https://apisix.apache.org/docs/apisix/installation-guide/)。

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org