You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 11:06:17 UTC
[GitHub] [flink] SteNicholas opened a new pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
SteNicholas opened a new pull request #14332:
URL: https://github.com/apache/flink/pull/14332
## What is the purpose of the change
*`FatalExitExceptionHandler` and `JvmShutdownSafeguard` use the same exit code (-17), making it impossible to distinguish the cause of an unexpected Flink JVM exit based on the exit code alone. Enum `ExitCode` should be introduced that defines all possible exit codes in Flink. The exit codes are different for `FatalExitExceptionHandler` and `JvmShutdownSafeguard`.*
## Brief change log
- *Add `ExitCode` enum to indicate the associated process exit code.*
- *Change the exit code in `FatalExitExceptionHandler` to be different from `JvmShutdownSafeguard`.*
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14332:
URL: https://github.com/apache/flink/pull/14332#issuecomment-740564216
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8e049e34d987d836d476f4feca4892c036c8a91",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8e049e34d987d836d476f4feca4892c036c8a91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8e049e34d987d836d476f4feca4892c036c8a91 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14332:
URL: https://github.com/apache/flink/pull/14332#issuecomment-740553344
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d8e049e34d987d836d476f4feca4892c036c8a91 (Tue Dec 08 11:07:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol closed pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #14332:
URL: https://github.com/apache/flink/pull/14332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14332:
URL: https://github.com/apache/flink/pull/14332#discussion_r540486480
##########
File path: flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosTaskExecutorRunner.java
##########
@@ -33,14 +33,16 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static org.apache.flink.runtime.util.ExitCode.RUNNER_INIT;
+
/**
* The entry point for running a TaskManager in a Mesos container.
*/
public class MesosTaskExecutorRunner {
private static final Logger LOG = LoggerFactory.getLogger(MesosTaskExecutorRunner.class);
- private static final int INIT_ERROR_EXIT_CODE = 31;
+ private static final int INIT_ERROR_EXIT_CODE = RUNNER_INIT.getExitCode();
Review comment:
There's no benefit in keeping these fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14332:
URL: https://github.com/apache/flink/pull/14332#issuecomment-740564216
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8e049e34d987d836d476f4feca4892c036c8a91",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10639",
"triggerID" : "d8e049e34d987d836d476f4feca4892c036c8a91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8e049e34d987d836d476f4feca4892c036c8a91 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10639)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14332:
URL: https://github.com/apache/flink/pull/14332#issuecomment-763551383
I'm closing this PR because of inactivity and it having diverged from the code-base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14332:
URL: https://github.com/apache/flink/pull/14332#issuecomment-740564216
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8e049e34d987d836d476f4feca4892c036c8a91",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10639",
"triggerID" : "d8e049e34d987d836d476f4feca4892c036c8a91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8e049e34d987d836d476f4feca4892c036c8a91 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10639)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14332: [FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14332:
URL: https://github.com/apache/flink/pull/14332#discussion_r540487319
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ExitCode.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.util;
+
+/**
+ * Enumeration to indicate the associated process exit code.
+ */
+public enum ExitCode {
+
+ /** The exit code of the succeeded application process. */
+ SUCCESS(0),
+ /** The exit code for running a TaskExecutor in the container. */
+ RUNNER_INIT(31),
+ /** The exit code of the JVM process killed by the safeguard. */
+ JVM_SHUTDOWN(-17),
+ /** The exit code of the fatal handler for uncaught exceptions. */
+ FATAL_UNCAUGHT(-99);
Review comment:
The comments for all enums aren't ideal.
```suggestion
/** The process terminated successfully. */
SUCCESS(0),
/** The process failed in the initialization of the process. */
RUNNER_INIT(31),
/** The process was killed forcefully because the shutdown took too long. */
JVM_SHUTDOWN(-17),
/** The process was killed due to an uncaught fatal exception. */
FATAL_UNCAUGHT(-99);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org