[GitHub] [spark] gengliangwang commented on a change in pull request #24393: [SPARK-27490][SQL] File source V2: return correct result for Dataset.inputFiles()

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #24393: [SPARK-27490][SQL] File source V2: return correct result for Dataset.inputFiles()
URL: https://github.com/apache/spark/pull/24393#discussion_r276295790
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
 ##########
 @@ -770,13 +770,13 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
       val parquetDF = spark.read.parquet(parquetDir)
       assert(parquetDF.inputFiles.nonEmpty)
 
-      val jsonDir = new File(dir, "json").getCanonicalPath
-      df.write.json(jsonDir)
-      val jsonDF = spark.read.json(jsonDir)
-      assert(parquetDF.inputFiles.nonEmpty)
+      val csvDir = new File(dir, "csv").getCanonicalPath
 
 Review comment:
   Not sure if we should test enable/disable file source v2 for all the test cases, or just test with the default configuration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org