[jira] [Commented] (FLINK-6842) Uncomment or remove code in HadoopFileSystem

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075204#comment-16075204 ] 

ASF GitHub Bot commented on FLINK-6842:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4219
  
    The call to `hadoopConf.getClass` is no longer needed and the early `return null` could be removed.


> Uncomment or remove code in HadoopFileSystem
> --------------------------------------------
>
>                 Key: FLINK-6842
>                 URL: https://issues.apache.org/jira/browse/FLINK-6842
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: mingleizhang
>            Priority: Minor
>
> I've found the following code in {{HadoopFileSystem#getHadoopWrapperClassNameForFileSystem}}
> {code}
> Configuration hadoopConf = getHadoopConfiguration();
> Class<? extends org.apache.hadoop.fs.FileSystem> clazz;
> // We can activate this block once we drop Hadoop1 support (only hd2 has the getFileSystemClass-method)
> //try {
> //	clazz = org.apache.hadoop.fs.FileSystem.getFileSystemClass(scheme, hadoopConf);
> //} catch (IOException e) {
> //	LOG.info("Flink could not load the Hadoop File system implementation for scheme "+scheme);
> //	return null;
> //}
> clazz = hadoopConf.getClass("fs." + scheme + ".impl", null, org.apache.hadoop.fs.FileSystem.class);
> if (clazz != null && LOG.isDebugEnabled()) {
> 	LOG.debug("Flink supports {} with the Hadoop file system wrapper, impl {}", scheme, clazz);
> }
> return clazz;
> {code}
> Since we don't support hadoop1 anymore the commented code should either be activated or removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)