You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@solr.apache.org by Shawn Heisey <ap...@elyograg.org> on 2021/11/18 20:28:47 UTC
Should JVM Args list in Admin UI Dashboard be sorted?
It's been bugging me for a while that the JVM Args list in the Solr
Admin UI is sorted, not shown in the actual order the arguments appear
on the command that started Solr.
With the list of arguments sorted by the UI, you can't tell what the
actual order is. If you look at a process listing, the order can be
seen, but the admin UI is often the first thing people look at. I think
the admin UI should reflect the true argument order, not sort the list.
If there were a really large number of arguments, scanning an unsorted
list to find something specific might become difficult, but I don't
think a typical install has so many arguments that this is a practical
problem. Maybe there could be an checkbox option near the list to sort
it for situations where somebody actually wants to do that? I don't
know enough about UI design to be able to make that happen.
In server/solr-webapp/webapp/js/angular/controllers/index.js is this line:
$scope.commandLineArgs = data.jvm.jmx.commandLineArgs.sort();
I removed".sort()" from that line on an install of 8.11.0. On page
reload, the list was no longer sorted.
I figured I should ask people what they think before committing that
change. Thoughts?
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: Should JVM Args list in Admin UI Dashboard be sorted?
Posted by Mike Drob <md...@mdrob.com>.
If they are sorted, I would prefer that we use a stable sort so that folks
can be aware of which setting is in effect for "last one wins" situations.
I also would echo Gus's question to verify that the not-sorted version is
meaningful rather than shuffled.
If the sort we are using is not a stable sort, then we should fix that,
rather than giving up entirely.
On Fri, Nov 19, 2021 at 1:43 PM Gus Heck <gu...@gmail.com> wrote:
>
>> I removed".sort()" from that line on an install of 8.11.0. On page
>> reload, the list was no longer sorted.
>
>
> Not sorted in a way that matched the actual order sent? (Wondering how
> these are acquired by the UI... if it's held in a HashMap it might not be
> a useful lack of sort).
>
> On Thu, Nov 18, 2021 at 8:37 PM David Smiley <ds...@apache.org> wrote:
>
>> I also very much prefer it be sorted so my eyes can quickly find what I'm
>> looking for (or its absence).
>>
>> ~ David Smiley
>> Apache Lucene/Solr Search Developer
>> http://www.linkedin.com/in/davidwsmiley
>>
>>
>> On Thu, Nov 18, 2021 at 4:19 PM Jason Gerlowski <ge...@gmail.com>
>> wrote:
>>
>>> Personally I like having the arguments sorted. Usually when I look at
>>> this part of the Admin UI, I'm looking for the value of a particular
>>> CLI arg, and the alphabetical ordering makes it easy to jump right to
>>> the value I'm interested in.
>>>
>>> It's not often I'd come to the list and really care the exact order
>>> the args appear in. The only use case I could imagine for that is if
>>> a user has accidentally started Solr with a particular flag or param
>>> specified multiple times and needs to know which value "won". (And
>>> you could make the argument that even in that case, the user is best
>>> served by leaving the args sorted so they can discover their mistake
>>> more easily and fix their startup config.)
>>>
>>> That said, I don't care strongly and wouldn't lose a wink of sleep
>>> over this one way or another.
>>>
>>> Best,
>>>
>>> Jason
>>>
>>> On Thu, Nov 18, 2021 at 3:59 PM Eric Pugh
>>> <ep...@opensourceconnections.com> wrote:
>>> >
>>> > Works for me…. I don’t know that I have a strong reason to say that
>>> sorting is the way to go, and therefore can’t come up with a reason for a
>>> checkbox feature to do it either ;-).
>>> >
>>> >
>>> >
>>> > On Nov 18, 2021, at 3:28 PM, Shawn Heisey <ap...@elyograg.org> wrote:
>>> >
>>> > It's been bugging me for a while that the JVM Args list in the Solr
>>> Admin UI is sorted, not shown in the actual order the arguments appear on
>>> the command that started Solr.
>>> >
>>> > With the list of arguments sorted by the UI, you can't tell what the
>>> actual order is. If you look at a process listing, the order can be seen,
>>> but the admin UI is often the first thing people look at. I think the
>>> admin UI should reflect the true argument order, not sort the list.
>>> >
>>> > If there were a really large number of arguments, scanning an unsorted
>>> list to find something specific might become difficult, but I don't think a
>>> typical install has so many arguments that this is a practical problem.
>>> Maybe there could be an checkbox option near the list to sort it for
>>> situations where somebody actually wants to do that? I don't know enough
>>> about UI design to be able to make that happen.
>>> >
>>> > In server/solr-webapp/webapp/js/angular/controllers/index.js is this
>>> line:
>>> >
>>> > $scope.commandLineArgs = data.jvm.jmx.commandLineArgs.sort();
>>> >
>>> > I removed".sort()" from that line on an install of 8.11.0. On page
>>> reload, the list was no longer sorted.
>>> >
>>> > I figured I should ask people what they think before committing that
>>> change. Thoughts?
>>> >
>>> > Thanks,
>>> > Shawn
>>> >
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>> > For additional commands, e-mail: dev-help@solr.apache.org
>>> >
>>> >
>>> > _______________________
>>> > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467
>>> | http://www.opensourceconnections.com | My Free/Busy
>>> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>>> > This e-mail and all contents, including attachments, is considered to
>>> be Company Confidential unless explicitly stated otherwise, regardless of
>>> whether attachments are marked as such.
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>
>>>
>
> --
> http://www.needhamsoftware.com (work)
> http://www.the111shift.com (play)
>
Re: Should JVM Args list in Admin UI Dashboard be sorted?
Posted by Gus Heck <gu...@gmail.com>.
>
>
> I removed".sort()" from that line on an install of 8.11.0. On page
> reload, the list was no longer sorted.
Not sorted in a way that matched the actual order sent? (Wondering how
these are acquired by the UI... if it's held in a HashMap it might not be
a useful lack of sort).
On Thu, Nov 18, 2021 at 8:37 PM David Smiley <ds...@apache.org> wrote:
> I also very much prefer it be sorted so my eyes can quickly find what I'm
> looking for (or its absence).
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
> On Thu, Nov 18, 2021 at 4:19 PM Jason Gerlowski <ge...@gmail.com>
> wrote:
>
>> Personally I like having the arguments sorted. Usually when I look at
>> this part of the Admin UI, I'm looking for the value of a particular
>> CLI arg, and the alphabetical ordering makes it easy to jump right to
>> the value I'm interested in.
>>
>> It's not often I'd come to the list and really care the exact order
>> the args appear in. The only use case I could imagine for that is if
>> a user has accidentally started Solr with a particular flag or param
>> specified multiple times and needs to know which value "won". (And
>> you could make the argument that even in that case, the user is best
>> served by leaving the args sorted so they can discover their mistake
>> more easily and fix their startup config.)
>>
>> That said, I don't care strongly and wouldn't lose a wink of sleep
>> over this one way or another.
>>
>> Best,
>>
>> Jason
>>
>> On Thu, Nov 18, 2021 at 3:59 PM Eric Pugh
>> <ep...@opensourceconnections.com> wrote:
>> >
>> > Works for me…. I don’t know that I have a strong reason to say that
>> sorting is the way to go, and therefore can’t come up with a reason for a
>> checkbox feature to do it either ;-).
>> >
>> >
>> >
>> > On Nov 18, 2021, at 3:28 PM, Shawn Heisey <ap...@elyograg.org> wrote:
>> >
>> > It's been bugging me for a while that the JVM Args list in the Solr
>> Admin UI is sorted, not shown in the actual order the arguments appear on
>> the command that started Solr.
>> >
>> > With the list of arguments sorted by the UI, you can't tell what the
>> actual order is. If you look at a process listing, the order can be seen,
>> but the admin UI is often the first thing people look at. I think the
>> admin UI should reflect the true argument order, not sort the list.
>> >
>> > If there were a really large number of arguments, scanning an unsorted
>> list to find something specific might become difficult, but I don't think a
>> typical install has so many arguments that this is a practical problem.
>> Maybe there could be an checkbox option near the list to sort it for
>> situations where somebody actually wants to do that? I don't know enough
>> about UI design to be able to make that happen.
>> >
>> > In server/solr-webapp/webapp/js/angular/controllers/index.js is this
>> line:
>> >
>> > $scope.commandLineArgs = data.jvm.jmx.commandLineArgs.sort();
>> >
>> > I removed".sort()" from that line on an install of 8.11.0. On page
>> reload, the list was no longer sorted.
>> >
>> > I figured I should ask people what they think before committing that
>> change. Thoughts?
>> >
>> > Thanks,
>> > Shawn
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>> > For additional commands, e-mail: dev-help@solr.apache.org
>> >
>> >
>> > _______________________
>> > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467
>> | http://www.opensourceconnections.com | My Free/Busy
>> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>> > This e-mail and all contents, including attachments, is considered to
>> be Company Confidential unless explicitly stated otherwise, regardless of
>> whether attachments are marked as such.
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>> For additional commands, e-mail: dev-help@solr.apache.org
>>
>>
--
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)
Re: Should JVM Args list in Admin UI Dashboard be sorted?
Posted by David Smiley <ds...@apache.org>.
I also very much prefer it be sorted so my eyes can quickly find what I'm
looking for (or its absence).
~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley
On Thu, Nov 18, 2021 at 4:19 PM Jason Gerlowski <ge...@gmail.com>
wrote:
> Personally I like having the arguments sorted. Usually when I look at
> this part of the Admin UI, I'm looking for the value of a particular
> CLI arg, and the alphabetical ordering makes it easy to jump right to
> the value I'm interested in.
>
> It's not often I'd come to the list and really care the exact order
> the args appear in. The only use case I could imagine for that is if
> a user has accidentally started Solr with a particular flag or param
> specified multiple times and needs to know which value "won". (And
> you could make the argument that even in that case, the user is best
> served by leaving the args sorted so they can discover their mistake
> more easily and fix their startup config.)
>
> That said, I don't care strongly and wouldn't lose a wink of sleep
> over this one way or another.
>
> Best,
>
> Jason
>
> On Thu, Nov 18, 2021 at 3:59 PM Eric Pugh
> <ep...@opensourceconnections.com> wrote:
> >
> > Works for me…. I don’t know that I have a strong reason to say that
> sorting is the way to go, and therefore can’t come up with a reason for a
> checkbox feature to do it either ;-).
> >
> >
> >
> > On Nov 18, 2021, at 3:28 PM, Shawn Heisey <ap...@elyograg.org> wrote:
> >
> > It's been bugging me for a while that the JVM Args list in the Solr
> Admin UI is sorted, not shown in the actual order the arguments appear on
> the command that started Solr.
> >
> > With the list of arguments sorted by the UI, you can't tell what the
> actual order is. If you look at a process listing, the order can be seen,
> but the admin UI is often the first thing people look at. I think the
> admin UI should reflect the true argument order, not sort the list.
> >
> > If there were a really large number of arguments, scanning an unsorted
> list to find something specific might become difficult, but I don't think a
> typical install has so many arguments that this is a practical problem.
> Maybe there could be an checkbox option near the list to sort it for
> situations where somebody actually wants to do that? I don't know enough
> about UI design to be able to make that happen.
> >
> > In server/solr-webapp/webapp/js/angular/controllers/index.js is this
> line:
> >
> > $scope.commandLineArgs = data.jvm.jmx.commandLineArgs.sort();
> >
> > I removed".sort()" from that line on an install of 8.11.0. On page
> reload, the list was no longer sorted.
> >
> > I figured I should ask people what they think before committing that
> change. Thoughts?
> >
> > Thanks,
> > Shawn
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> > For additional commands, e-mail: dev-help@solr.apache.org
> >
> >
> > _______________________
> > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
> http://www.opensourceconnections.com | My Free/Busy
> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> > This e-mail and all contents, including attachments, is considered to be
> Company Confidential unless explicitly stated otherwise, regardless of
> whether attachments are marked as such.
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
Re: Should JVM Args list in Admin UI Dashboard be sorted?
Posted by Jason Gerlowski <ge...@gmail.com>.
Personally I like having the arguments sorted. Usually when I look at
this part of the Admin UI, I'm looking for the value of a particular
CLI arg, and the alphabetical ordering makes it easy to jump right to
the value I'm interested in.
It's not often I'd come to the list and really care the exact order
the args appear in. The only use case I could imagine for that is if
a user has accidentally started Solr with a particular flag or param
specified multiple times and needs to know which value "won". (And
you could make the argument that even in that case, the user is best
served by leaving the args sorted so they can discover their mistake
more easily and fix their startup config.)
That said, I don't care strongly and wouldn't lose a wink of sleep
over this one way or another.
Best,
Jason
On Thu, Nov 18, 2021 at 3:59 PM Eric Pugh
<ep...@opensourceconnections.com> wrote:
>
> Works for me…. I don’t know that I have a strong reason to say that sorting is the way to go, and therefore can’t come up with a reason for a checkbox feature to do it either ;-).
>
>
>
> On Nov 18, 2021, at 3:28 PM, Shawn Heisey <ap...@elyograg.org> wrote:
>
> It's been bugging me for a while that the JVM Args list in the Solr Admin UI is sorted, not shown in the actual order the arguments appear on the command that started Solr.
>
> With the list of arguments sorted by the UI, you can't tell what the actual order is. If you look at a process listing, the order can be seen, but the admin UI is often the first thing people look at. I think the admin UI should reflect the true argument order, not sort the list.
>
> If there were a really large number of arguments, scanning an unsorted list to find something specific might become difficult, but I don't think a typical install has so many arguments that this is a practical problem. Maybe there could be an checkbox option near the list to sort it for situations where somebody actually wants to do that? I don't know enough about UI design to be able to make that happen.
>
> In server/solr-webapp/webapp/js/angular/controllers/index.js is this line:
>
> $scope.commandLineArgs = data.jvm.jmx.commandLineArgs.sort();
>
> I removed".sort()" from that line on an install of 8.11.0. On page reload, the list was no longer sorted.
>
> I figured I should ask people what they think before committing that change. Thoughts?
>
> Thanks,
> Shawn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
> _______________________
> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: Should JVM Args list in Admin UI Dashboard be sorted?
Posted by Eric Pugh <ep...@opensourceconnections.com>.
Works for me…. I don’t know that I have a strong reason to say that sorting is the way to go, and therefore can’t come up with a reason for a checkbox feature to do it either ;-).
> On Nov 18, 2021, at 3:28 PM, Shawn Heisey <ap...@elyograg.org> wrote:
>
> It's been bugging me for a while that the JVM Args list in the Solr Admin UI is sorted, not shown in the actual order the arguments appear on the command that started Solr.
>
> With the list of arguments sorted by the UI, you can't tell what the actual order is. If you look at a process listing, the order can be seen, but the admin UI is often the first thing people look at. I think the admin UI should reflect the true argument order, not sort the list.
>
> If there were a really large number of arguments, scanning an unsorted list to find something specific might become difficult, but I don't think a typical install has so many arguments that this is a practical problem. Maybe there could be an checkbox option near the list to sort it for situations where somebody actually wants to do that? I don't know enough about UI design to be able to make that happen.
>
> In server/solr-webapp/webapp/js/angular/controllers/index.js is this line:
>
> $scope.commandLineArgs = data.jvm.jmx.commandLineArgs.sort();
>
> I removed".sort()" from that line on an install of 8.11.0. On page reload, the list was no longer sorted.
>
> I figured I should ask people what they think before committing that change. Thoughts?
>
> Thanks,
> Shawn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.