[GitHub] [beam] pabloem commented on a change in pull request #16373: [BEAM-13515] [Playground] Hiding lines in an example that are not necessary

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #16373:
URL: https://github.com/apache/beam/pull/16373#discussion_r788260733



##########
File path: playground/frontend/lib/modules/editor/components/editor_textarea.dart
##########
@@ -31,6 +31,15 @@ import 'package:playground/modules/examples/models/example_model.dart';
 import 'package:playground/modules/sdk/models/sdk.dart';
 import 'package:provider/provider.dart';
 
+const kNumberOfStringsToSkip = 16;
+const kJavaRegExp = r'import\s[A-z.0-9]*\;\n\n[(\/\*\*)|(public)|(class)]';
+const kPythonRegExp = r'[^\S\r\n](import|as)[^\S\r\n][A-z]*\n\n';
+const kGoRegExp = r'[^\S\r\n]+\'
+    r'"'
+    r'.*'
+    r'"'
+    r'\n\)\n\n';
+

Review comment:
       I think this is fine as a workaround, but I would like to support examples to have a tag `scroll-to-line: 123` or something like that - so that we're not having to guess how much to scroll programatically. What do you think about this? Is this something you can do?
   
   If not, can you create a JIRA issue to keep this in mind? Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org