You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/07 07:46:04 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #11031:
[FLINK-15914][checkpointing][metrics] Miss the checkpoint related metrics
for the case of two inputs
zhijiangW commented on a change in pull request #11031: [FLINK-15914][checkpointing][metrics] Miss the checkpoint related metrics for the case of two inputs
URL: https://github.com/apache/flink/pull/11031#discussion_r376251803
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
##########
@@ -233,15 +234,17 @@ public long getLatestCheckpointId() {
*
* @return The duration in nanoseconds
*/
- public long getAlignmentDurationNanos() {
+ @VisibleForTesting
Review comment:
It is actually used in many tests in `CheckpointBarrierAlignerTestBase`. I ever tried to refactor these tests to use these two methods from `CheckpointBarrierHandler` directly, then we can remove them from `CheckpointedInputGate`. But it would bring more refactoring work after checking the codes for exposing the `CheckpointBarrierHandler` while constructing the gate. So I still keep the current way now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services