You are viewing a plain text version of this content. The canonical link for it is here.
Posted to kato-dev@incubator.apache.org by Steve Poole <sp...@googlemail.com> on 2009/03/03 17:27:31 UTC
Status of code contribution from IBM
Since I'm in email writing mode I thought I'd give an update on IBM's
contribution to Apache Kato.
The saga is almost over - I expect to see the CCLA appear in the next few
days. Of course I've been saying that for sometime but now it looks like we
are just waiting for a signature from an Exec.
Steve
Re: Status of code contribution from IBM
Posted by Steve Poole <sp...@googlemail.com>.
On Tue, Mar 17, 2009 at 3:05 PM, Mark Hindess
<ma...@googlemail.com>wrote:
>
> In message <85...@mail.gmail.com>,
> Carmine Cristallo writes:
> >
> > Ciao!
> > We've committed the code under trunk/import (as specified here:
> > http://incubator.apache.org/guides/mentor.html#clean-up-best-practice
> > )
> > Now... our assumption is that the "import" directory is there only to
> > contain the initial code contribution, and that we need to do a svn
> > copy of the whole thing into trunk to start the actual development, Is
> > this correct? In this case, should we also copy the NOTICE and LICENSE
> > files from trunk/import into trunk?
>
> You now have kato/trunk/import which means everyone checking out the
> working-in-progress code also gets a copy of the original import. I
> doubt very much that this was what was originally intended by the
> author of the best practice document.
>
> I'd probably:
>
> svn move https://.../kato/trunk/import \
> https://.../kato/branches/import
>
> unless one of your mentors has a better suggestion.
>
No other suggests were made so I've done as you suggested.
>
> Other minor issues I spotted as the commit messages went by ...
>
>
> org.apache.kato.tools.jdi/src/com/ibm/tools/jdi/DTFJReader.java lines
> 220 and 263 contain typos of the word 'attempted'.
>
>
> Some of the */.settings/org.eclipse.jdt.ui.prefs files contain templates
> with things like "Property of IBM" which probably wont be appropriate
> for new files.
>
> Fixed.
>
> It is probably worth doing:
>
> svn propset svn:eol-style native filename
>
> on all the text/code files so all developers see line endings
> consistently for their OS. Committers should probably consider using
> http://www.apache.org/dev/svn-eol-style.txt to ensure that new files are
> created with this property. The spurious whitespace changes in commit
> messages you get if you don't set this can be really misleading so it is
> good to get this right from the start.
>
> Congratulations on the first commit. Nice work.
>
> Regards,
> Mark.
>
>
>
Re: Status of code contribution from IBM
Posted by Mark Hindess <ma...@googlemail.com>.
In message <85...@mail.gmail.com>,
Carmine Cristallo writes:
>
> Ciao!
> We've committed the code under trunk/import (as specified here:
> http://incubator.apache.org/guides/mentor.html#clean-up-best-practice
> )
> Now... our assumption is that the "import" directory is there only to
> contain the initial code contribution, and that we need to do a svn
> copy of the whole thing into trunk to start the actual development, Is
> this correct? In this case, should we also copy the NOTICE and LICENSE
> files from trunk/import into trunk?
You now have kato/trunk/import which means everyone checking out the
working-in-progress code also gets a copy of the original import. I
doubt very much that this was what was originally intended by the
author of the best practice document.
I'd probably:
svn move https://.../kato/trunk/import \
https://.../kato/branches/import
unless one of your mentors has a better suggestion.
Other minor issues I spotted as the commit messages went by ...
org.apache.kato.tools.jdi/src/com/ibm/tools/jdi/DTFJReader.java lines
220 and 263 contain typos of the word 'attempted'.
Some of the */.settings/org.eclipse.jdt.ui.prefs files contain templates
with things like "Property of IBM" which probably wont be appropriate
for new files.
It is probably worth doing:
svn propset svn:eol-style native filename
on all the text/code files so all developers see line endings
consistently for their OS. Committers should probably consider using
http://www.apache.org/dev/svn-eol-style.txt to ensure that new files are
created with this property. The spurious whitespace changes in commit
messages you get if you don't set this can be really misleading so it is
good to get this right from the start.
Congratulations on the first commit. Nice work.
Regards,
Mark.
Re: Status of code contribution from IBM
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Mon, Mar 16, 2009 at 5:15 PM, Carmine Cristallo
<ca...@gmail.com> wrote:
> Ciao!
> We've committed the code under trunk/import (as specified here:
> http://incubator.apache.org/guides/mentor.html#clean-up-best-practice
> )
> Now... our assumption is that the "import" directory is there only to
> contain the initial code contribution, and that we need to do a svn
> copy of the whole thing into trunk to start the actual development, Is
> this correct?
i think so
> In this case, should we also copy the NOTICE and LICENSE
> files from trunk/import into trunk?
yes
- robert
Re: Status of code contribution from IBM
Posted by Carmine Cristallo <ca...@gmail.com>.
Ciao!
We've committed the code under trunk/import (as specified here:
http://incubator.apache.org/guides/mentor.html#clean-up-best-practice
)
Now... our assumption is that the "import" directory is there only to
contain the initial code contribution, and that we need to do a svn
copy of the whole thing into trunk to start the actual development, Is
this correct? In this case, should we also copy the NOTICE and LICENSE
files from trunk/import into trunk?
Thank you!
Carmine
On Mon, Mar 16, 2009 at 1:16 PM, ant elder <an...@apache.org> wrote:
> Those two sound fine to me, once thats done any committer can commit
> it to svn and close the jira.
>
> ...ant
>
> On Mon, Mar 16, 2009 at 1:05 PM, Carmine Cristallo
> <ca...@gmail.com> wrote:
>> Now that we have received the acknowledge of the reception of the
>> CCLA, we're ready to contribute the code.
>> This is my understanding about what needs to be done next:
>>
>> 1. create a JIRA issue named "Initial code contribution". Should its
>> type be a "new feature"?
>> 2. attach the zip file containing the code to contribute and the md5
>> file to the issue
>>
>> Is this correct?
>> What happens next? At what point will the code go into svn? Who needs
>> to close the issue, and at what point?
>>
>> Thank you!
>>
>>
>> Carmine
>>
>> On Mon, Mar 16, 2009 at 11:45 AM, ant elder <an...@gmail.com> wrote:
>>> This has been received and filed at
>>> documents/grants/InternationalBusinessMachinesCorp.pdf.
>>>
>>> ...ant
>>>
>>> On Tue, Mar 10, 2009 at 3:22 PM, Stuart Monteith <st...@stoo.me.uk> wrote:
>>>> I've just sent the CCLA to secretary@apache.org, almost there....
>>>>
>>>>
>>>> Robert Burrell Donkin wrote:
>>>>>
>>>>> On Tue, Mar 3, 2009 at 5:27 PM, Steve Poole <sp...@googlemail.com>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> Since I'm in email writing mode I thought I'd give an update on IBM's
>>>>>> contribution to Apache Kato.
>>>>>>
>>>>>> The saga is almost over - I expect to see the CCLA appear in the next
>>>>>> few
>>>>>> days. Of course I've been saying that for sometime but now it looks like
>>>>>> we
>>>>>> are just waiting for a signature from an Exec.
>>>>>>
>>>>>
>>>>> great :-)
>>>>>
>>>>> - robert
>>>>>
>>>>
>>>
>>
>
Re: Status of code contribution from IBM
Posted by ant elder <an...@apache.org>.
Those two sound fine to me, once thats done any committer can commit
it to svn and close the jira.
...ant
On Mon, Mar 16, 2009 at 1:05 PM, Carmine Cristallo
<ca...@gmail.com> wrote:
> Now that we have received the acknowledge of the reception of the
> CCLA, we're ready to contribute the code.
> This is my understanding about what needs to be done next:
>
> 1. create a JIRA issue named "Initial code contribution". Should its
> type be a "new feature"?
> 2. attach the zip file containing the code to contribute and the md5
> file to the issue
>
> Is this correct?
> What happens next? At what point will the code go into svn? Who needs
> to close the issue, and at what point?
>
> Thank you!
>
>
> Carmine
>
> On Mon, Mar 16, 2009 at 11:45 AM, ant elder <an...@gmail.com> wrote:
>> This has been received and filed at
>> documents/grants/InternationalBusinessMachinesCorp.pdf.
>>
>> ...ant
>>
>> On Tue, Mar 10, 2009 at 3:22 PM, Stuart Monteith <st...@stoo.me.uk> wrote:
>>> I've just sent the CCLA to secretary@apache.org, almost there....
>>>
>>>
>>> Robert Burrell Donkin wrote:
>>>>
>>>> On Tue, Mar 3, 2009 at 5:27 PM, Steve Poole <sp...@googlemail.com>
>>>> wrote:
>>>>
>>>>>
>>>>> Since I'm in email writing mode I thought I'd give an update on IBM's
>>>>> contribution to Apache Kato.
>>>>>
>>>>> The saga is almost over - I expect to see the CCLA appear in the next
>>>>> few
>>>>> days. Of course I've been saying that for sometime but now it looks like
>>>>> we
>>>>> are just waiting for a signature from an Exec.
>>>>>
>>>>
>>>> great :-)
>>>>
>>>> - robert
>>>>
>>>
>>
>
Re: Status of code contribution from IBM
Posted by Carmine Cristallo <ca...@gmail.com>.
Now that we have received the acknowledge of the reception of the
CCLA, we're ready to contribute the code.
This is my understanding about what needs to be done next:
1. create a JIRA issue named "Initial code contribution". Should its
type be a "new feature"?
2. attach the zip file containing the code to contribute and the md5
file to the issue
Is this correct?
What happens next? At what point will the code go into svn? Who needs
to close the issue, and at what point?
Thank you!
Carmine
On Mon, Mar 16, 2009 at 11:45 AM, ant elder <an...@gmail.com> wrote:
> This has been received and filed at
> documents/grants/InternationalBusinessMachinesCorp.pdf.
>
> ...ant
>
> On Tue, Mar 10, 2009 at 3:22 PM, Stuart Monteith <st...@stoo.me.uk> wrote:
>> I've just sent the CCLA to secretary@apache.org, almost there....
>>
>>
>> Robert Burrell Donkin wrote:
>>>
>>> On Tue, Mar 3, 2009 at 5:27 PM, Steve Poole <sp...@googlemail.com>
>>> wrote:
>>>
>>>>
>>>> Since I'm in email writing mode I thought I'd give an update on IBM's
>>>> contribution to Apache Kato.
>>>>
>>>> The saga is almost over - I expect to see the CCLA appear in the next
>>>> few
>>>> days. Of course I've been saying that for sometime but now it looks like
>>>> we
>>>> are just waiting for a signature from an Exec.
>>>>
>>>
>>> great :-)
>>>
>>> - robert
>>>
>>
>
Re: Status of code contribution from IBM
Posted by ant elder <an...@gmail.com>.
This has been received and filed at
documents/grants/InternationalBusinessMachinesCorp.pdf.
...ant
On Tue, Mar 10, 2009 at 3:22 PM, Stuart Monteith <st...@stoo.me.uk> wrote:
> I've just sent the CCLA to secretary@apache.org, almost there....
>
>
> Robert Burrell Donkin wrote:
>>
>> On Tue, Mar 3, 2009 at 5:27 PM, Steve Poole <sp...@googlemail.com>
>> wrote:
>>
>>>
>>> Since I'm in email writing mode I thought I'd give an update on IBM's
>>> contribution to Apache Kato.
>>>
>>> The saga is almost over - I expect to see the CCLA appear in the next
>>> few
>>> days. Of course I've been saying that for sometime but now it looks like
>>> we
>>> are just waiting for a signature from an Exec.
>>>
>>
>> great :-)
>>
>> - robert
>>
>
Re: Status of code contribution from IBM
Posted by Stuart Monteith <st...@stoo.me.uk>.
I've just sent the CCLA to secretary@apache.org, almost there....
Robert Burrell Donkin wrote:
> On Tue, Mar 3, 2009 at 5:27 PM, Steve Poole <sp...@googlemail.com> wrote:
>
>> Since I'm in email writing mode I thought I'd give an update on IBM's
>> contribution to Apache Kato.
>>
>> The saga is almost over - I expect to see the CCLA appear in the next few
>> days. Of course I've been saying that for sometime but now it looks like we
>> are just waiting for a signature from an Exec.
>>
>
> great :-)
>
> - robert
>
Re: Status of code contribution from IBM
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Tue, Mar 3, 2009 at 5:27 PM, Steve Poole <sp...@googlemail.com> wrote:
> Since I'm in email writing mode I thought I'd give an update on IBM's
> contribution to Apache Kato.
>
> The saga is almost over - I expect to see the CCLA appear in the next few
> days. Of course I've been saying that for sometime but now it looks like we
> are just waiting for a signature from an Exec.
great :-)
- robert