You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/10 09:19:27 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7371: Refactor InsertStatement, add subclass for different databases.

tristaZero commented on a change in pull request #7371:
URL: https://github.com/apache/shardingsphere/pull/7371#discussion_r486191417



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/InsertStatement.java
##########
@@ -43,7 +43,7 @@
  */
 @Getter
 @Setter
-public final class InsertStatement extends AbstractSQLStatement implements DMLStatement {
+public abstract class InsertStatement extends AbstractSQLStatement {

Review comment:
       Since some segments are just for the particular database, it is required to review and split these segments into its child classes, IMO. Like `WithSegment` is supposed to appear in `SQLServerInsertStatement`, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org