You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Yong Zhang <zh...@gmail.com> on 2022/04/01 01:41:08 UTC
Re: Cutting a release out of branch-4.14
Thank you very much!
Another question about the cherry-pick is, does the cherry-pick step
always handled by who merged the PR? And when a bug fix is merged,
looks like we rarely label to mark release to some minor version?
Yong
On Thu, 31 Mar 2022 at 15:10, Enrico Olivelli <eo...@gmail.com> wrote:
> Yong,
>
> Il giorno gio 31 mar 2022 alle ore 08:32 Yong Zhang <yo...@apache.org>
> ha scritto:
> >
> > Hi Nicolò Boschi,
> >
> > I want to include those PR into the 4.14.5 release
> > https://github.com/apache/bookkeeper/pull/2642/
>
> Waiting for CI
>
> > https://github.com/apache/bookkeeper/pull/3144
>
> Merged and cherry-picked to branch-4.14
>
>
> Enrico
> >
> > Thanks!
> >
> >
> > On Thu, 31 Mar 2022 at 06:45, Nicolò Boschi <bo...@gmail.com>
> wrote:
> >
> > > I found out that Spotbugs check doesn't pass.
> > > With an unlucky combination, the configuration has changed and we only
> > > check for warnings with level=High (since when we migrated CI to
> gradle, I
> > > believe it was unintended)
> > > The story in short:
> > > - Spotbugs on jdk11 has always been disabled
> > > - We migrated CI to gradle with a different configuration
> > > - New warnings happened but silently ignored
> > > - We migrated CI to jdk11
> > > - We migrated back to maven but keeping jdk11 as default jdk (and then
> > > spotbugs not enabled)
> > > - branch-4.14 is still with JDK8 CI
> > >
> > > I sent a PR to fix it on the master branch. we should apply it to
> > > branch-4.14 and maybe 4.15 (?).
> > > I've seen the problem because I've created a pull against 4.14 and the
> CI
> > > failed
> > >
> > > Pull: https://github.com/apache/bookkeeper/pull/3160
> > >
> > > Luckily I don't see critical issues. If we are not confident to
> cherry-pick
> > > this pull before cutting the release, I'm okay to go ahead with 4.14.5
> > > without these changes.
> > >
> > > Let me know what you think
> > > BR,
> > > Nicolò Boschi
> > >
> > >
> > > Il giorno mer 30 mar 2022 alle ore 14:06 Enrico Olivelli <
> > > eolivelli@gmail.com> ha scritto:
> > >
> > > > Il giorno mer 30 mar 2022 alle ore 13:52 Nicolò Boschi
> > > > <bo...@gmail.com> ha scritto:
> > > > >
> > > > > I'd love to do that if it's okay for you
> > > >
> > > > Sure
> > > > Thank you
> > > >
> > > > Ping me if you need any help
> > > >
> > > > Enrico
> > > >
> > > > >
> > > > > Nicolò Boschi
> > > > >
> > > > >
> > > > > Il giorno gio 24 mar 2022 alle ore 09:25 Enrico Olivelli <
> > > > > eolivelli@gmail.com> ha scritto:
> > > > >
> > > > > > Hello,
> > > > > > we have a fix for a bad bug that may cause data corruption.
> > > > > > https://github.com/apache/bookkeeper/pull/3110
> > > > > >
> > > > > > I have cherry-picked it to branch-4.14.
> > > > > > Any volunteers for a release ?
> > > > > >
> > > > > > Enrico
> > > > > >
> > > >
> > >
>
Re: Cutting a release out of branch-4.14
Posted by Nicolò Boschi <bo...@gmail.com>.
I cherry-picked all the commits marked with release-4.14.5 (
https://github.com/apache/bookkeeper/labels/release%2F4.14.5) except for
https://github.com/apache/bookkeeper/pull/2790 which requires another
review from Andrey.
After that, I will start the release process.
Nicolò Boschi
Il giorno ven 1 apr 2022 alle ore 13:33 Enrico Olivelli <eo...@gmail.com>
ha scritto:
> Il Ven 1 Apr 2022, 03:41 Yong Zhang <zh...@gmail.com> ha
> scritto:
>
> > Thank you very much!
> >
> > Another question about the cherry-pick is, does the cherry-pick step
> > always handled by who merged the PR? And when a bug fix is merged,
> > looks like we rarely label to mark release to some minor version?
> >
>
> You can cherry pick commits that you think are necessary and they don't
> break anything.
>
> Things that should NOT be cherry picked usually:
> - breaking changes, API, protocol, disk, metadata.
> - New features (small enhancements may be if the risk is small)
>
>
> Enrico
>
>
> > Yong
> >
> > On Thu, 31 Mar 2022 at 15:10, Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> > > Yong,
> > >
> > > Il giorno gio 31 mar 2022 alle ore 08:32 Yong Zhang <yo...@apache.org>
> > > ha scritto:
> > > >
> > > > Hi Nicolò Boschi,
> > > >
> > > > I want to include those PR into the 4.14.5 release
> > > > https://github.com/apache/bookkeeper/pull/2642/
> > >
> > > Waiting for CI
> > >
> > > > https://github.com/apache/bookkeeper/pull/3144
> > >
> > > Merged and cherry-picked to branch-4.14
> > >
> > >
> > > Enrico
> > > >
> > > > Thanks!
> > > >
> > > >
> > > > On Thu, 31 Mar 2022 at 06:45, Nicolò Boschi <bo...@gmail.com>
> > > wrote:
> > > >
> > > > > I found out that Spotbugs check doesn't pass.
> > > > > With an unlucky combination, the configuration has changed and we
> > only
> > > > > check for warnings with level=High (since when we migrated CI to
> > > gradle, I
> > > > > believe it was unintended)
> > > > > The story in short:
> > > > > - Spotbugs on jdk11 has always been disabled
> > > > > - We migrated CI to gradle with a different configuration
> > > > > - New warnings happened but silently ignored
> > > > > - We migrated CI to jdk11
> > > > > - We migrated back to maven but keeping jdk11 as default jdk (and
> > then
> > > > > spotbugs not enabled)
> > > > > - branch-4.14 is still with JDK8 CI
> > > > >
> > > > > I sent a PR to fix it on the master branch. we should apply it to
> > > > > branch-4.14 and maybe 4.15 (?).
> > > > > I've seen the problem because I've created a pull against 4.14 and
> > the
> > > CI
> > > > > failed
> > > > >
> > > > > Pull: https://github.com/apache/bookkeeper/pull/3160
> > > > >
> > > > > Luckily I don't see critical issues. If we are not confident to
> > > cherry-pick
> > > > > this pull before cutting the release, I'm okay to go ahead with
> > 4.14.5
> > > > > without these changes.
> > > > >
> > > > > Let me know what you think
> > > > > BR,
> > > > > Nicolò Boschi
> > > > >
> > > > >
> > > > > Il giorno mer 30 mar 2022 alle ore 14:06 Enrico Olivelli <
> > > > > eolivelli@gmail.com> ha scritto:
> > > > >
> > > > > > Il giorno mer 30 mar 2022 alle ore 13:52 Nicolò Boschi
> > > > > > <bo...@gmail.com> ha scritto:
> > > > > > >
> > > > > > > I'd love to do that if it's okay for you
> > > > > >
> > > > > > Sure
> > > > > > Thank you
> > > > > >
> > > > > > Ping me if you need any help
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > > >
> > > > > > > Nicolò Boschi
> > > > > > >
> > > > > > >
> > > > > > > Il giorno gio 24 mar 2022 alle ore 09:25 Enrico Olivelli <
> > > > > > > eolivelli@gmail.com> ha scritto:
> > > > > > >
> > > > > > > > Hello,
> > > > > > > > we have a fix for a bad bug that may cause data corruption.
> > > > > > > > https://github.com/apache/bookkeeper/pull/3110
> > > > > > > >
> > > > > > > > I have cherry-picked it to branch-4.14.
> > > > > > > > Any volunteers for a release ?
> > > > > > > >
> > > > > > > > Enrico
> > > > > > > >
> > > > > >
> > > > >
> > >
> >
>
Re: Cutting a release out of branch-4.14
Posted by Enrico Olivelli <eo...@gmail.com>.
Il Ven 1 Apr 2022, 03:41 Yong Zhang <zh...@gmail.com> ha scritto:
> Thank you very much!
>
> Another question about the cherry-pick is, does the cherry-pick step
> always handled by who merged the PR? And when a bug fix is merged,
> looks like we rarely label to mark release to some minor version?
>
You can cherry pick commits that you think are necessary and they don't
break anything.
Things that should NOT be cherry picked usually:
- breaking changes, API, protocol, disk, metadata.
- New features (small enhancements may be if the risk is small)
Enrico
> Yong
>
> On Thu, 31 Mar 2022 at 15:10, Enrico Olivelli <eo...@gmail.com> wrote:
>
> > Yong,
> >
> > Il giorno gio 31 mar 2022 alle ore 08:32 Yong Zhang <yo...@apache.org>
> > ha scritto:
> > >
> > > Hi Nicolò Boschi,
> > >
> > > I want to include those PR into the 4.14.5 release
> > > https://github.com/apache/bookkeeper/pull/2642/
> >
> > Waiting for CI
> >
> > > https://github.com/apache/bookkeeper/pull/3144
> >
> > Merged and cherry-picked to branch-4.14
> >
> >
> > Enrico
> > >
> > > Thanks!
> > >
> > >
> > > On Thu, 31 Mar 2022 at 06:45, Nicolò Boschi <bo...@gmail.com>
> > wrote:
> > >
> > > > I found out that Spotbugs check doesn't pass.
> > > > With an unlucky combination, the configuration has changed and we
> only
> > > > check for warnings with level=High (since when we migrated CI to
> > gradle, I
> > > > believe it was unintended)
> > > > The story in short:
> > > > - Spotbugs on jdk11 has always been disabled
> > > > - We migrated CI to gradle with a different configuration
> > > > - New warnings happened but silently ignored
> > > > - We migrated CI to jdk11
> > > > - We migrated back to maven but keeping jdk11 as default jdk (and
> then
> > > > spotbugs not enabled)
> > > > - branch-4.14 is still with JDK8 CI
> > > >
> > > > I sent a PR to fix it on the master branch. we should apply it to
> > > > branch-4.14 and maybe 4.15 (?).
> > > > I've seen the problem because I've created a pull against 4.14 and
> the
> > CI
> > > > failed
> > > >
> > > > Pull: https://github.com/apache/bookkeeper/pull/3160
> > > >
> > > > Luckily I don't see critical issues. If we are not confident to
> > cherry-pick
> > > > this pull before cutting the release, I'm okay to go ahead with
> 4.14.5
> > > > without these changes.
> > > >
> > > > Let me know what you think
> > > > BR,
> > > > Nicolò Boschi
> > > >
> > > >
> > > > Il giorno mer 30 mar 2022 alle ore 14:06 Enrico Olivelli <
> > > > eolivelli@gmail.com> ha scritto:
> > > >
> > > > > Il giorno mer 30 mar 2022 alle ore 13:52 Nicolò Boschi
> > > > > <bo...@gmail.com> ha scritto:
> > > > > >
> > > > > > I'd love to do that if it's okay for you
> > > > >
> > > > > Sure
> > > > > Thank you
> > > > >
> > > > > Ping me if you need any help
> > > > >
> > > > > Enrico
> > > > >
> > > > > >
> > > > > > Nicolò Boschi
> > > > > >
> > > > > >
> > > > > > Il giorno gio 24 mar 2022 alle ore 09:25 Enrico Olivelli <
> > > > > > eolivelli@gmail.com> ha scritto:
> > > > > >
> > > > > > > Hello,
> > > > > > > we have a fix for a bad bug that may cause data corruption.
> > > > > > > https://github.com/apache/bookkeeper/pull/3110
> > > > > > >
> > > > > > > I have cherry-picked it to branch-4.14.
> > > > > > > Any volunteers for a release ?
> > > > > > >
> > > > > > > Enrico
> > > > > > >
> > > > >
> > > >
> >
>