You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by el...@apache.org on 2018/06/08 04:49:12 UTC
[13/19] lucene-solr:solr-6733: LUCENE-8273: Don't wrap ShingleFilter
in conditions in testRandomChains
LUCENE-8273: Don't wrap ShingleFilter in conditions in testRandomChains
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a4fa1689
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a4fa1689
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a4fa1689
Branch: refs/heads/solr-6733
Commit: a4fa16896225e08b72bf64fba97a216bb6a83fbb
Parents: a82c9cf
Author: Alan Woodward <ro...@apache.org>
Authored: Thu Jun 7 12:53:43 2018 +0100
Committer: Alan Woodward <ro...@apache.org>
Committed: Thu Jun 7 12:54:10 2018 +0100
----------------------------------------------------------------------
.../test/org/apache/lucene/analysis/core/TestRandomChains.java | 5 +++++
1 file changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a4fa1689/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
----------------------------------------------------------------------
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
index d94b396..fd6f4b5 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
@@ -88,6 +88,7 @@ import org.apache.lucene.analysis.path.PathHierarchyTokenizer;
import org.apache.lucene.analysis.path.ReversePathHierarchyTokenizer;
import org.apache.lucene.analysis.payloads.IdentityEncoder;
import org.apache.lucene.analysis.payloads.PayloadEncoder;
+import org.apache.lucene.analysis.shingle.ShingleFilter;
import org.apache.lucene.analysis.snowball.TestSnowball;
import org.apache.lucene.analysis.standard.StandardTokenizer;
import org.apache.lucene.analysis.synonym.SynonymMap;
@@ -124,6 +125,10 @@ public class TestRandomChains extends BaseTokenStreamTestCase {
avoidConditionals.add(FingerprintFilter.class);
avoidConditionals.add(MinHashFilter.class);
avoidConditionals.add(ConcatenateGraphFilter.class);
+ // ShingleFilter doesn't handle input graphs correctly, so wrapping it in a condition can
+ // expose inconsistent offsets
+ // https://issues.apache.org/jira/browse/LUCENE-4170
+ avoidConditionals.add(ShingleFilter.class);
}
private static final Map<Constructor<?>,Predicate<Object[]>> brokenConstructors = new HashMap<>();