You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by zhenzhao wang <wz...@gmail.com> on 2018/07/13 22:08:27 UTC

Re: Review Request 67917: FLUME-3256: Adding Register Service Component and Zookeeper registration for service discovery

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67917/
-----------------------------------------------------------

(Updated July 13, 2018, 10:08 p.m.)


Review request for Flume and Ferenc Szabo.


Changes
-------

Link jira


Summary (updated)
-----------------

FLUME-3256: Adding Register Service Component and Zookeeper registration for service discovery


Bugs: FLUME-3256
    https://issues.apache.org/jira/browse/FLUME-3256


Repository: flume-git


Description
-------

We're going to introduce following feature/function in the patch:

1. Adding a register service component interface so developer could develop their own agent service registration machoism for source process.
2. A zookeeper register service which will create node on Zookeeper with service url. So clients could use zookeeper to find available flume agents.


Diffs
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/BasicConfigurationConstants.java 3f23e62 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java b7bab15 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java f1e3a8c 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java e6c7875 
  flume-ng-configuration/src/test/java/org/apache/flume/conf/TestFlumeConfiguration.java a881d00 
  flume-ng-configuration/src/test/java/org/apache/flume/conf/TestFlumeConfigurationConfigFilter.java ada2d8f 
  flume-ng-core/pom.xml 3d72aba 
  flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorBuilderFactory.java 7c64613 
  flume-ng-core/src/main/java/org/apache/flume/register/service/AbstractRegisterService.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/register/service/RegisterService.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/register/service/RegisterServiceFactory.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/register/service/ZooKeeperRegisterService.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/register/service/TestZooKeeperRegisterService.java PRE-CREATION 
  flume-ng-doc/sphinx/FlumeUserGuide.rst af91f9e 
  flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java ae59444 
  flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java 130bc64 
  flume-ng-node/src/main/java/org/apache/flume/node/Application.java 7111f60 
  flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java fa3ef55 
  flume-ng-node/src/main/java/org/apache/flume/node/SimpleMaterializedConfiguration.java fa58dff 


Diff: https://reviews.apache.org/r/67917/diff/1/


Testing
-------

1. Unit test done. 
2. It had been used internally for years, however there're difference between this patch and our internal patch.


Thanks,

zhenzhao wang


Re: Review Request 67917: FLUME-3256: Adding Register Service Component and Zookeeper registration for service discovery

Posted by zhenzhao wang <wz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67917/
-----------------------------------------------------------

(Updated July 13, 2018, 11:30 p.m.)


Review request for Flume and Ferenc Szabo.


Changes
-------

Add some missing files


Bugs: FLUME-3256
    https://issues.apache.org/jira/browse/FLUME-3256


Repository: flume-git


Description
-------

We're going to introduce following feature/function in the patch:

1. Adding a register service component interface so developer could develop their own agent service registration machoism for source process.
2. A zookeeper register service which will create node on Zookeeper with service url. So clients could use zookeeper to find available flume agents.


Diffs (updated)
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/BasicConfigurationConstants.java 3f23e62 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java b7bab15 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java f1e3a8c 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java e6c7875 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/register/service/RegisterServiceConfiguration.java PRE-CREATION 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/register/service/RegisterServiceType.java PRE-CREATION 
  flume-ng-configuration/src/test/java/org/apache/flume/conf/TestFlumeConfiguration.java a881d00 
  flume-ng-configuration/src/test/java/org/apache/flume/conf/TestFlumeConfigurationConfigFilter.java ada2d8f 
  flume-ng-core/pom.xml 3d72aba 
  flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorBuilderFactory.java 7c64613 
  flume-ng-core/src/main/java/org/apache/flume/register/service/AbstractRegisterService.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/register/service/RegisterService.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/register/service/RegisterServiceFactory.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/register/service/ZooKeeperRegisterService.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/register/service/TestZooKeeperRegisterService.java PRE-CREATION 
  flume-ng-doc/sphinx/FlumeUserGuide.rst af91f9e 
  flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java ae59444 
  flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java 130bc64 
  flume-ng-node/src/main/java/org/apache/flume/node/Application.java 7111f60 
  flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java fa3ef55 
  flume-ng-node/src/main/java/org/apache/flume/node/SimpleMaterializedConfiguration.java fa58dff 


Diff: https://reviews.apache.org/r/67917/diff/2/

Changes: https://reviews.apache.org/r/67917/diff/1-2/


Testing
-------

1. Unit test done. 
2. It had been used internally for years, however there're difference between this patch and our internal patch.


Thanks,

zhenzhao wang