[CALCITE-4181] Re: Request for assistance with CALCITE-4181

[Khuê Nguyễn Trần Tú <nt...@gmail.com>]

Hello,

I sent the email below back in September regarding the following issue:

https://issues.apache.org/jira/browse/CALCITE-4181

I'm still looking for any guidance and a review if there's anyone who might
be able to assist please? I'm hoping it can be merged, or if not, to
understand why. Thanks!

> I believe I've found and fixed a bug documented in JIRA ticket
> CALCITE-4181,
> but perhaps I've missed the mark since I'm not very familiar with avatica
> overall.
> Ultimately I'm just trying to correct for a change in behaviour
> noticed in Apache nifi downstream when a select field is a list of a java
> object like List<MapRecord>.
>
> The change does pass all tests I was able to run, is there anyone who
might
> be able to review?

Best Regards,
Kent Nguyen

Re: [CALCITE-4181] Re: Request for assistance with CALCITE-4181

[Khuê Nguyễn Trần Tú <nt...@gmail.com>]

Hello,

I would like to follow up on this bug. The thrown exception really blocks a
common use case we have.

I have squashed the commits in pull request 126:

https://github.com/apache/calcite-avatica/pull/126

Please let me know anything else I can do to get it merged and resolve the
issue.

Thanks a lot.

Kent Nguyen


On Fri, Dec 11, 2020 at 3:12 PM Khuê Nguyễn Trần Tú <nt...@gmail.com>
wrote:

> Hi Vladimir,
>
> > Could you please add a test that reproduces the issue?
>
> Thanks for your reply. I have now updated the pull request, adding 3 more
> unit tests to try and demonstrate the bug:
>
> https://github.com/apache/calcite-avatica/pull/126,
>
> Without my change, the test results are:
>
> arraysOfStructs(): pass
> listOfStructs(): pass
> arrayOfJavaObjects(): pass
> listOfJavaObjects(): fail
>
> When the change is applied, the last test case listOfJavaObject() will
> also pass.
>
> Please let me know if there's anything else I should address.
>
> Thanks,
> Kent Nguyen
>
> On Mon, Dec 7, 2020 at 12:54 PM Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
>> Could you please add a test that reproduces the issue?
>>
>> Vladimir
>>
>

Re: [CALCITE-4181] Re: Request for assistance with CALCITE-4181

[Khuê Nguyễn Trần Tú <nt...@gmail.com>]

Hi Vladimir,

> Could you please add a test that reproduces the issue?

Thanks for your reply. I have now updated the pull request, adding 3 more
unit tests to try and demonstrate the bug:

https://github.com/apache/calcite-avatica/pull/126,

Without my change, the test results are:

arraysOfStructs(): pass
listOfStructs(): pass
arrayOfJavaObjects(): pass
listOfJavaObjects(): fail

When the change is applied, the last test case listOfJavaObject() will also
pass.

Please let me know if there's anything else I should address.

Thanks,
Kent Nguyen

On Mon, Dec 7, 2020 at 12:54 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:

> Could you please add a test that reproduces the issue?
>
> Vladimir
>

Re: [CALCITE-4181] Re: Request for assistance with CALCITE-4181

[Vladimir Sitnikov <si...@gmail.com>]

Could you please add a test that reproduces the issue?

Vladimir