You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2024/11/12 19:25:59 UTC
[Impala-ASF-CR] IMPALA-13541: Calcite planner, declare explicit cast in operator table.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22057
Change subject: IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
......................................................................
IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
This fixes a regression caused by IMPALA-13516.
The validator finds the explicit_cast function when the cast to
timestamp function is present in the query. However, the validator
then tries to validate the explicit_cast function which was not
present in the operator table. Placing the operator in the table
fixes the issue.
Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/22057/1
--
To view, visit http://gerrit.cloudera.org:8080/22057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
Gerrit-Change-Number: 22057
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-13541: Calcite planner, declare explicit cast in operator table.
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22057 )
Change subject: IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
......................................................................
IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
This fixes a regression caused by IMPALA-13516.
The validator finds the explicit_cast function when the cast to
timestamp function is present in the query. However, the validator
then tries to validate the explicit_cast function which was not
present in the operator table. Placing the operator in the table
fixes the issue.
Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
Reviewed-on: http://gerrit.cloudera.org:8080/22057
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
Gerrit-Change-Number: 22057
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-13541: Calcite planner, declare explicit cast in operator table.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22057 )
Change subject: IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/17440/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
Gerrit-Change-Number: 22057
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 19:49:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13541: Calcite planner, declare explicit cast in operator table.
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22057 )
Change subject: IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22057/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22057/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
This would have been fine as an addendum to IMPALA-13516, new ticket not really needed.
--
To view, visit http://gerrit.cloudera.org:8080/22057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
Gerrit-Change-Number: 22057
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 19:41:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13541: Calcite planner, declare explicit cast in operator table.
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22057 )
Change subject: IMPALA-13541: Calcite planner, declare explicit_cast in operator table.
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Verified locally. Build issue is unrelated, from https://gerrit.cloudera.org/c/21932/.
--
To view, visit http://gerrit.cloudera.org:8080/22057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8577a06178435f5048d0a9721c16069ebe05743
Gerrit-Change-Number: 22057
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Nov 2024 00:48:44 +0000
Gerrit-HasComments: No