You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/22 00:21:40 UTC
[jira] Created: (ZOOKEEPER-587) client should log timeout
negotiated with server
client should log timeout negotiated with server
------------------------------------------------
Key: ZOOKEEPER-587
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
Project: Zookeeper
Issue Type: Bug
Components: c client, java client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Fix For: 3.3.0
The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-587:
-----------------------------------
Status: Open (was: Patch Available)
I should be logging this in the server log as well.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-587:
-----------------------------------
Attachment: ZOOKEEPER-587.patch
this patch adds negotiated timeout to both the c and java log messages
I also add the destination server for the session to the java message (already on c log message)
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-587:
------------------------------------
Hadoop Flags: [Reviewed]
+1 looks good.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781332#action_12781332 ]
Hadoop QA commented on ZOOKEEPER-587:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425811/ZOOKEEPER-587.patch
against trunk revision 882744.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/console
This message is automatically generated.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781737#action_12781737 ]
Hadoop QA commented on ZOOKEEPER-587:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425919/ZOOKEEPER-587.patch
against trunk revision 882744.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/console
This message is automatically generated.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-587:
-----------------------------------
Status: Patch Available (was: Open)
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-587:
-----------------------------------
Assignee: Patrick Hunt
Status: Patch Available (was: Open)
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790086#action_12790086 ]
Hudson commented on ZOOKEEPER-587:
----------------------------------
Integrated in ZooKeeper-trunk #625 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/])
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781074#action_12781074 ]
stack commented on ZOOKEEPER-587:
---------------------------------
If server changes the timeout on the client, yeah, for sure at least log it. Good stuff.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Fix For: 3.3.0
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-587:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. thanks pat.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781741#action_12781741 ]
Mahadev konar commented on ZOOKEEPER-587:
-----------------------------------------
+1 the patch looks good.
Though we sshould add apis for getting the sesssion timeout. In c we have zoo_recv_timeout (which sadly doesnt have any docs on it) but in java we dont have any. We should add it and document saying that the session timeout is negotiated and how and why. This could be another jira!
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-587:
-----------------------------------
Attachment: ZOOKEEPER-587.patch
Updated server to log message.
Note there are no tests for this - it's a logging change only. Already exercised by existing code.
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-587) client should log timeout
negotiated with server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-587:
-----------------------------------
Labels: logging (was: )
> client should log timeout negotiated with server
> ------------------------------------------------
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.