You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/09/11 14:10:43 UTC
[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/308
CB-9521 Do not pass removed platform to `after_platform_rm` hook
This fixes annoying issue, already described in [CB-9521](issues.apache.org/jira/browse/CB-9521).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9521
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #308
----
commit 318aa24420a49b7954e6cc97bd50ea44a3d509a8
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-09-11T12:08:49Z
CB-9521 Do not pass removed platform to `after_platform_rm` hook
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-lib/pull/308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/308#issuecomment-141555326
Closing this as there is some uncertainty in hook parameters specification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/308#discussion_r39896066
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -363,6 +363,7 @@ function remove(hooksRunner, projectRoot, targets, opts) {
platformMetadata.remove(projectRoot, target);
});
}).then(function() {
+ opts.cordova.platforms = cordova_util.listPlatforms(opts.projectRoot);
--- End diff --
@vladimir-kotikov probably the root reason of the issue is in hooksRunner.opts.platforms [being set in platforms.js](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/platform.js#L570) and then used in [refineOpts in HooksRunner](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/hooks/HooksRunner.js#L69) - we will need to refine the way context.opts.cordova.platforms is used and properly document it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org