You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Noel J. Bergman" <no...@devtech.com> on 2002/11/24 21:04:47 UTC
[PATCH][VOTE] AbstractJdbcUsersRepository.java
For those of you not following the thread on james-user, we found a JDBC
resource leak that impacts Oracle users seriously (out of resources).
As stated there on james-user:
"This is a bug, and it really ought to be fixed. The change is
well-understood, used in all other areas, and easily tested. We know that
we have a number of Oracle users, and this is a resource leak for them. I
just checked my private tree against the CVS, and I don't have any other
differences that would be termed a serious or potentially wide-spread
defect. We ought to vote on whether we would prefer to support the Release
with or without the fix."
The code is simply that there is one method (out of all the other similar
places) where the common pattern we use everywhere else had not been
implemented. The change is attached, and consists of the following:
1. move two declarations out of a try block so that they
are available to the finally clause.
2. add the close statements to the existing finally clause.
We have to support the Release. I would prefer not to have to point Oracle
users at a patch or immediately issue a point release.
+1 to commit the change pending successful testing by the Oracle user who is
working with us on james-user, as well as normal testing.
--- Noel
Re: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Serge Knystautas <se...@lokitech.com>.
Noel J. Bergman wrote:
> The code is simply that there is one method (out of all the other similar
> places) where the common pattern we use everywhere else had not been
> implemented. The change is attached, and consists of the following:
>
> 1. move two declarations out of a try block so that they
> are available to the finally clause.
>
> 2. add the close statements to the existing finally clause.
>
> We have to support the Release. I would prefer not to have to point Oracle
> users at a patch or immediately issue a point release.
>
> +1 to commit the change pending successful testing by the Oracle user who is
> working with us on james-user, as well as normal testing.
+1
--
Serge Knystautas
Loki Technologies
http://www.lokitech.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Darrell DeBoer <da...@apache.org>.
On Mon, 25 Nov 2002 06:04, Noel J. Bergman wrote:
> For those of you not following the thread on james-user, we found a JDBC
> resource leak that impacts Oracle users seriously (out of resources).
>
> As stated there on james-user:
>
> "This is a bug, and it really ought to be fixed. The change is
> well-understood, used in all other areas, and easily tested. We know that
> we have a number of Oracle users, and this is a resource leak for them. I
> just checked my private tree against the CVS, and I don't have any other
> differences that would be termed a serious or potentially wide-spread
> defect. We ought to vote on whether we would prefer to support the Release
> with or without the fix."
>
> The code is simply that there is one method (out of all the other similar
> places) where the common pattern we use everywhere else had not been
> implemented. The change is attached, and consists of the following:
>
> 1. move two declarations out of a try block so that they
> are available to the finally clause.
>
> 2. add the close statements to the existing finally clause.
>
> We have to support the Release. I would prefer not to have to point Oracle
> users at a patch or immediately issue a point release.
>
> +1 to commit the change pending successful testing by the Oracle user who
> is working with us on james-user, as well as normal testing.
>
> --- Noel
+1
--
ciao,
Daz
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Automating site and build updates
Posted by Nicola Ken Barozzi <ni...@apache.org>.
Noel J. Bergman wrote:
> Nicola,
>
> Where does Forrest run? My understanding is that it would be running on my
> build machine, rather than nagoya, which is what was behind my comment.
It can be, which BTW Andy is doing (acoliver at apache.org has a script
ready using Centipede BTW), but we are musing over making it run itself
as a single Forrest run for all sites that ask for it.
Forrest had been running as a test on outerthought.net, but now we still
have to understand-decide where to run it now.
Latest possibility is to use Gump, which has a feature that can make it
publish stuff, but IIRC it's not yet ready for prime time.
> --- Noel
>
> -----Original Message-----
> From: Nicola Ken Barozzi [mailto:nicolaken@apache.org]
> Sent: Tuesday, November 26, 2002 3:37
> To: James Developers List
> Subject: Re: Automating site and build updates
>
>
>
>
> Noel J. Bergman wrote:
> [...]
>
>>I suppose that once we've adopted Maven and/or Forrest, we can enhance the
>>script(s) to do the web site updates, too.
>
>
> Forrest has a bot that does site updates called forrestbot.
> There are security issues related with automatic site updates that we're
> resolving. It's part of the Forrest goals that to do automatic site updates.
>
> --
> Nicola Ken Barozzi nicolaken@apache.org
> - verba volant, scripta manent -
> (discussions get forgotten, just code remains)
> ---------------------------------------------------------------------
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
>
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by "Noel J. Bergman" <no...@devtech.com>.
Nicola,
Where does Forrest run? My understanding is that it would be running on my
build machine, rather than nagoya, which is what was behind my comment.
--- Noel
-----Original Message-----
From: Nicola Ken Barozzi [mailto:nicolaken@apache.org]
Sent: Tuesday, November 26, 2002 3:37
To: James Developers List
Subject: Re: Automating site and build updates
Noel J. Bergman wrote:
[...]
> I suppose that once we've adopted Maven and/or Forrest, we can enhance the
> script(s) to do the web site updates, too.
Forrest has a bot that does site updates called forrestbot.
There are security issues related with automatic site updates that we're
resolving. It's part of the Forrest goals that to do automatic site updates.
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Automating site and build updates
Posted by Nicola Ken Barozzi <ni...@apache.org>.
Noel J. Bergman wrote:
[...]
> I suppose that once we've adopted Maven and/or Forrest, we can enhance the
> script(s) to do the web site updates, too.
Forrest has a bot that does site updates called forrestbot.
There are security issues related with automatic site updates that we're
resolving. It's part of the Forrest goals that to do automatic site updates.
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Automating site and build updates
Posted by "Noel J. Bergman" <no...@devtech.com>.
Danny,
> As I've said before, if someone has a machine on which
> they can make *clean* builds and can upload them to
> their home dir on cvs.apache
I have a system we can do that on, and I am willing to setup a separate copy
of the CVS for doing clean builds. I could probably use some help
automating the process.
Right now, I have cvs and ssh setup to use pki, so interactive login
shouldn't be an issue. What I'd need to do is have a cron job that updates
from the cvs, does the build, and then either [produces the files and uses
scp to move them to a directory under ~noel], or sends e-mail regarding the
build failure. If there are no changes in the CVS, I suppose that it
shouldn't actually do anything.
Do you have something suitable?
I suppose that once we've adopted Maven and/or Forrest, we can enhance the
script(s) to do the web site updates, too.
> 1/ IMO it helps if you change the name of the archive files
in build.xml to include either a date or a version [...]
> 2/ Then TAG the HEAD with this command in the root of
jakarta-james:cvs tag <version>
Let's just put it into the scripts.
But in the meantime, we still need to get that Milestone build posted
manually from Peter's directory. :-)
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Danny Angus <da...@apache.org>.
> An automated build process (perhaps Gump/Alexandria, although that seems
> to serve a different purpose) that would generate nightly builds off a
> pure, unadulterated CVS of the source. A milestone build would just be
> a particular nightly build that was moved into a "milestone" directory.
> This would make it easy to i) generate milestones and release and ii)
> keep track of the exact binaries we've distributed. All committers
> would have necessary write access to the relevant directories, so any
> committer could put out a milestone. Releases would basically be
> handled identically to milestones. Having set this up in a commercial
> environment (although we used Perforce and not CVS) I know that it's not
> particularly difficult. Especially with Ant in the picture. But we can
> hash this out later, after the current release is out the door.
As I've said before, if someone has a machine on which they can make *clean* builds (preferably linux, to preserve permissions) and can upload them to their home dir on cvs.apache, or grant me read access on their machine, I'd be quite happy to set up a cron job on my daedalus account to pull the build into the downloads site.
The build process would ideally date-stamp the archive files to avoid confusion.
I may yet be in a position to do this myself.
d.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
Noel,
> > In the future I hope to abandon this rather silly process.
>
> What do you have in mind?
An automated build process (perhaps Gump/Alexandria, although that seems
to serve a different purpose) that would generate nightly builds off a
pure, unadulterated CVS of the source. A milestone build would just be
a particular nightly build that was moved into a "milestone" directory.
This would make it easy to i) generate milestones and release and ii)
keep track of the exact binaries we've distributed. All committers
would have necessary write access to the relevant directories, so any
committer could put out a milestone. Releases would basically be
handled identically to milestones. Having set this up in a commercial
environment (although we used Perforce and not CVS) I know that it's not
particularly difficult. Especially with Ant in the picture. But we can
hash this out later, after the current release is out the door.
--Peter
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Noel J. Bergman" <no...@devtech.com>.
> In the future I hope to abandon this rather silly process.
What do you have in mind?
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
> In other words, Danny or Serge (or other with Daedalus access) just
needs
> to
> copy from ~pgoldstein/downloads/downloads/ to the nightly build
directory?
> I should hope that doesn't take but a matter of a moment, but perhaps
you
> might indicate specifically which file(s)?
All of them.
> In the future, perhaps you might address immediate needs of short
duration
> by placing the download under a public_html/ in your home directory,
so
> that
> cvs.apache.org/~pgoldstein/<file> is available.
In the future I hope to abandon this rather silly process.
--Peter
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by Danny Angus <da...@apache.org>.
its donw but fyi its /www/jakarta.apache.org/builds/jakarta-james/latest
> -----Original Message-----
> From: Harmeet Bedi [mailto:harmeet@kodemuse.com]
> Sent: 26 November 2002 00:42
> To: James Developers List
> Subject: Re: Automating site and build updates
>
>
> ----- Original Message -----
> From: "Noel J. Bergman" <no...@devtech.com>
> > scp -pr cvs.apache.org:~pgoldstein/downloads/downloads/* to wherever
> > /builds/jakarta-james/latest/ exists on daedelus.
>
> Where is /builds/jakarta-james/latest/ . Don't remember and
> couldn't locate
> easily.
>
> Danny do you have the instructions on how to do this. I don't want to do a
> find or anything like that on daedalus.
>
> Harmeet
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Automating site and build updates
Posted by Harmeet Bedi <ha...@kodemuse.com>.
----- Original Message -----
From: "Noel J. Bergman" <no...@devtech.com>
> scp -pr cvs.apache.org:~pgoldstein/downloads/downloads/* to wherever
> /builds/jakarta-james/latest/ exists on daedelus.
Where is /builds/jakarta-james/latest/ . Don't remember and couldn't locate
easily.
Danny do you have the instructions on how to do this. I don't want to do a
find or anything like that on daedalus.
Harmeet
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by "Noel J. Bergman" <no...@devtech.com>.
Harmeet,
scp -pr cvs.apache.org:~pgoldstein/downloads/downloads/* to wherever
/builds/jakarta-james/latest/ exists on daedelus.
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Automating site and build updates
Posted by Harmeet Bedi <ha...@kodemuse.com>.
----- Original Message -----
From: "Noel J. Bergman" <no...@devtech.com>
> Danny,
>
> Whom else has daedalus access? Is it reasonable to have more than one
> person? Does Serge have it?
I have one, can copy build over... let me know.
Network connections should not be down for long. So I would expect that
Danny's connection should be up soon. Danny, if the problem is direct path
to daedalus, you can hop into daedalus via an intermediate ssh/telnet server
like icarus.
Harmeet
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by Danny Angus <da...@apache.org>.
I think you just have to ask root. 's all I did.
d.
> -----Original Message-----
> From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> Sent: 27 November 2002 06:06
> To: 'James Developers List'
> Subject: RE: Automating site and build updates
>
>
>
> > > Also, if Danny and I are too slow in making the updates to daedalus
> and
> > > Peter is going to be the release manager for the foreseeable future,
> I
> > > would think we could get him an account there.
> >
> > +1
> >
> > I should have the time to be release manager for the next one, or let
> > Peter do it again.
>
> If it counts for anything, +1 to giving me an account on daedalus. :)
>
> --Peter
>
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
> > Also, if Danny and I are too slow in making the updates to daedalus
and
> > Peter is going to be the release manager for the foreseeable future,
I
> > would think we could get him an account there.
>
> +1
>
> I should have the time to be release manager for the next one, or let
> Peter do it again.
If it counts for anything, +1 to giving me an account on daedalus. :)
--Peter
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by Danny Angus <da...@apache.org>.
> Also, if Danny and I are too slow in making the updates to daedalus and
> Peter is going to be the release manager for the foreseeable future, I
> would think we could get him an account there.
+1
I should have the time to be release manager for the next one, or let Peter do it again.
d.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Automating site and build updates
Posted by Serge Knystautas <se...@lokitech.com>.
Noel J. Bergman wrote:
> Danny,
>
> Whom else has daedalus access? Is it reasonable to have more than one
> person? Does Serge have it?
>
> I assume that one of your thoughts is that by putting the cron job on your
> daedelus account, that it will cut down on the need for human intervention
> on a regular basis.
>
> --- Noel
Ok, finally checked and I do have access on both.
Automated builds sound nice for nightly snapshots, but this seems like a
question where we need to create a specific release, i.e., specify the
version tag in the build process (e.g. 2.x RCy), tag in CVS, then deploy.
Also, if Danny and I are too slow in making the updates to daedalus and
Peter is going to be the release manager for the foreseeable future, I
would think we could get him an account there.
--
Serge Knystautas
Loki Technologies - Unstoppable Websites
http://www.lokitech.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Automating site and build updates
Posted by Danny Angus <da...@apache.org>.
> Whom else has daedalus access? Is it reasonable to have more than one
> person? Does Serge have it?
Don't know
> I assume that one of your thoughts is that by putting the cron job on your
> daedelus account, that it will cut down on the need for human intervention
> on a regular basis.
Yes, exactly that.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
re: Automating site and build updates
Posted by "Noel J. Bergman" <no...@devtech.com>.
Danny,
Whom else has daedalus access? Is it reasonable to have more than one
person? Does Serge have it?
I assume that one of your thoughts is that by putting the cron job on your
daedelus account, that it will cut down on the need for human intervention
on a regular basis.
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Danny Angus <da...@apache.org>.
Done now. :-)
d.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
Danny,
Ok. Well, let us know when you get access again. Thanks.
--Peter
> -----Original Message-----
> From: Danny Angus [mailto:danny@apache.org]
> Sent: Monday, November 25, 2002 11:44 AM
> To: James Developers List; farsight@alum.mit.edu
> Subject: RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
>
> not until I can get acces to the servers :-( some kind of network
problem
> at my end.
>
> > -----Original Message-----
> > From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> > Sent: 25 November 2002 17:57
> > To: 'James Developers List'
> > Subject: RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
> >
> >
> >
> > Danny,
> >
> > > A mere instant of attention is required.
> >
> > Can we get that instant of attention. The files were uploaded
> > yesterday.
> >
> > --Peter
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail: <mailto:james-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:james-dev-
> help@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Danny Angus <da...@apache.org>.
not until I can get acces to the servers :-( some kind of network problem at my end.
> -----Original Message-----
> From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> Sent: 25 November 2002 17:57
> To: 'James Developers List'
> Subject: RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
>
>
>
> Danny,
>
> > A mere instant of attention is required.
>
> Can we get that instant of attention. The files were uploaded
> yesterday.
>
> --Peter
>
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
Danny,
> A mere instant of attention is required.
Can we get that instant of attention. The files were uploaded
yesterday.
--Peter
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Danny Angus <da...@apache.org>.
> In other words, Danny or Serge (or other with Daedalus access)
> just needs to
> copy from ~pgoldstein/downloads/downloads/ to the nightly build directory?
> I should hope that doesn't take but a matter of a moment, but perhaps you
> might indicate specifically which file(s)?
A mere instant of attention is required.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Noel J. Bergman" <no...@devtech.com>.
> To speed the process, I've applied the patch, build a dist, and am
> uploading to a public directory in my home directory on cvs.apache.org.
In other words, Danny or Serge (or other with Daedalus access) just needs to
copy from ~pgoldstein/downloads/downloads/ to the nightly build directory?
I should hope that doesn't take but a matter of a moment, but perhaps you
might indicate specifically which file(s)?
In the future, perhaps you might address immediate needs of short duration
by placing the download under a public_html/ in your home directory, so that
cvs.apache.org/~pgoldstein/<file> is available.
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Serge Knystautas <se...@lokitech.com>.
I would agree... I would recommend we make this RC2. I definitely would
like to avoid support emails saying "Oh you're running rc1? can you
download that again in case you have the older rc1"?
--
Serge Knystautas
Loki Technologies
http://www.lokitech.com/
Danny Angus wrote:
> +0
> And .. I agree with Peters points
> And .. I'll upload the build if its ready
> And .. two version control points:
>
> 1/ IMO it helps if you change the name of the archive files in build.xml to include either a date or a version, and increment the version (either the minor number or the modifier a,b,rc, this avoids users confusion with any other builds. We should ensure builds have unique names
> 2/ Then TAG the HEAD with this command in the root of jakarta-james:
> cvs tag <version>
> where version might be 2.1rc1
>
> d.
>
>
>
>
>>I'd prefer that too, but there are other considerations. I'll be
>>willing to vote +1 on this provided that we can get the new milestone
>>build up and posted by 24 hours from the date of this email. I don't
>>have appropriate access to daedalus, so I can't guarantee that. If we
>>can get someone with that access to guarantee that, I've got no problem
>>with this fix. Otherwise I've got concerns that this will further push
>>out an already delayed release.
>>
>>To speed the process, I've applied the patch, build a dist, and am
>>uploading to a public directory in my home directory on cvs.apache.org.
>>This will enable Danny or someone else just to copy it into the nightly
>>build directory.
>>
>>If we can't make this timeframe I'll have to vote -1. Getting 2.1 out
>>the door is a very high priority, even if it means we leave some issues
>>unaddressed. This issue affects only a small segment of our user base.
>>If necessary, we'll issue that point release.
>>
>>--Peter
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by Danny Angus <da...@apache.org>.
+0
And .. I agree with Peters points
And .. I'll upload the build if its ready
And .. two version control points:
1/ IMO it helps if you change the name of the archive files in build.xml to include either a date or a version, and increment the version (either the minor number or the modifier a,b,rc, this avoids users confusion with any other builds. We should ensure builds have unique names
2/ Then TAG the HEAD with this command in the root of jakarta-james:
cvs tag <version>
where version might be 2.1rc1
d.
> I'd prefer that too, but there are other considerations. I'll be
> willing to vote +1 on this provided that we can get the new milestone
> build up and posted by 24 hours from the date of this email. I don't
> have appropriate access to daedalus, so I can't guarantee that. If we
> can get someone with that access to guarantee that, I've got no problem
> with this fix. Otherwise I've got concerns that this will further push
> out an already delayed release.
>
> To speed the process, I've applied the patch, build a dist, and am
> uploading to a public directory in my home directory on cvs.apache.org.
> This will enable Danny or someone else just to copy it into the nightly
> build directory.
>
> If we can't make this timeframe I'll have to vote -1. Getting 2.1 out
> the door is a very high priority, even if it means we leave some issues
> unaddressed. This issue affects only a small segment of our user base.
> If necessary, we'll issue that point release.
>
> --Peter
>
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH][VOTE] AbstractJdbcUsersRepository.java
Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
Noel,
> We have to support the Release. I would prefer not to have to point
> Oracle
> users at a patch or immediately issue a point release.
>
> +1 to commit the change pending successful testing by the Oracle user
who
> is
> working with us on james-user, as well as normal testing.
I'd prefer that too, but there are other considerations. I'll be
willing to vote +1 on this provided that we can get the new milestone
build up and posted by 24 hours from the date of this email. I don't
have appropriate access to daedalus, so I can't guarantee that. If we
can get someone with that access to guarantee that, I've got no problem
with this fix. Otherwise I've got concerns that this will further push
out an already delayed release.
To speed the process, I've applied the patch, build a dist, and am
uploading to a public directory in my home directory on cvs.apache.org.
This will enable Danny or someone else just to copy it into the nightly
build directory.
If we can't make this timeframe I'll have to vote -1. Getting 2.1 out
the door is a very high priority, even if it means we leave some issues
unaddressed. This issue affects only a small segment of our user base.
If necessary, we'll issue that point release.
--Peter
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>