You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "akashsawan1 (via GitHub)" <gi...@apache.org> on 2023/04/13 01:22:53 UTC
[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java
akashsawan1 opened a new pull request, #3710:
URL: https://github.com/apache/eventmesh/pull/3710
Closes#<3408>
Motivation
Explain why you want to make the changes and what problem you're trying to solve.
I am contributing for the first time, it will help to keep me motivated to learn and help the community
Modifications
Describe the modifications you've done.
Did some code optimization in line 246,336
Documentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3710:
URL: https://github.com/apache/eventmesh/pull/3710#discussion_r1164869907
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncRemoteEventProcessor.java:
##########
@@ -243,7 +243,8 @@ public void handler(final HandlerService.HandlerSpecific handlerSpecific, final
return;
}
- final String content = event.getData() == null ? "" : new String(event.getData().toBytes(), StandardCharsets.UTF_8);
+ final String content = event.getData() == null ? ""
Review Comment:
There is one NPE to control here:
```
final String content = event.getData() == null ? "" :
new String(Objects.requireNonNull(event.getData()).toBytes(), StandardCharsets.UTF_8);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3710:
URL: https://github.com/apache/eventmesh/pull/3710#issuecomment-1506446107
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3710](https://codecov.io/gh/apache/eventmesh/pull/3710?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2fdc37) into [master](https://codecov.io/gh/apache/eventmesh/commit/36036dac908e35df76bd2e899cc44bee0be4640a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36036da) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c2fdc37 differs from pull request most recent head d4391f6. Consider uploading reports for the commit d4391f6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3710 +/- ##
============================================
- Coverage 13.76% 13.75% -0.02%
Complexity 1291 1291
============================================
Files 571 571
Lines 29239 29233 -6
Branches 2884 2872 -12
============================================
- Hits 4024 4020 -4
+ Misses 24841 24840 -1
+ Partials 374 373 -1
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../http/processor/SendAsyncRemoteEventProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvU2VuZEFzeW5jUmVtb3RlRXZlbnRQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3710/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 closed pull request #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 closed pull request #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java
URL: https://github.com/apache/eventmesh/pull/3710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org