Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

["Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>]

Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1739981694


##########
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##########
@@ -141,6 +141,16 @@ public synchronized void subscribe(Pattern pattern) {
         subscribe(pattern, Optional.empty());
     }
 
+    @Override
+    public void subscribe(SubscriptionPattern pattern, ConsumerRebalanceListener callback) {
+

Review Comment:
   @AndrewJSchofield, just a question, why do we need to adapt the implementation of `subscribe(Pattern pattern, ConsumerRebalanceListener callback)`  while the `SubscriptionPattern` is to be resolved on the broker, not locally like `Pattern.` If we go that route the `MockConsumer` won't really simulate how the `AsyncConsumer` works



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org